Fix connector-loading e2e: hoist resolver flags to all CLI commands

Two bugs:
1. `--no-connectors-from-path` only worked on `serve`, not on one-shot
   commands like `check`. Fix: pre-parse connector flags from process.argv
   before building the resolver, and declare them as rootArgs so all
   subcommands accept them.
2. Test helpers passed `--stripe-api-key`/`--postgres-url` which aren't
   real flags on the generated `check` command (they were silently ignored).
   Fix: pass `--x-sync-params` with the full JSON blob instead.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Committed-By-Agent: claude

Author: tonyxiao

apps/engine/src/cli/command.ts

@@ -2,29 +2,35 @@ import 'dotenv/config'
 import { Readable } from 'node:stream'
 import { defineCommand } from 'citty'
 import { createCliFromSpec } from '@stripe/sync-ts-cli/openapi'
+import { parseJsonOrFile } from '@stripe/sync-ts-cli'
 import { createConnectorResolver } from '../lib/index.js'
 import { createApp } from '../api/app.js'
 import { serveAction } from '../serve-command.js'
 
+/** Connector discovery flags shared by all commands (serve + one-shot). */
+const connectorArgs = {
+  connectorsFromCommandMap: {
+    type: 'string' as const,
+    description: 'Explicit connector command mappings (JSON object or @file)',
+  },
+  noConnectorsFromPath: {
+    type: 'boolean' as const,
+    default: false,
+    description: 'Disable PATH-based connector discovery',
+  },
+  connectorsFromNpm: {
+    type: 'boolean' as const,
+    default: false,
+    description: 'Enable npm auto-download of connectors (disabled by default)',
+  },
+}
+
 // Hand-written workflow command: start HTTP server
 const serveCmd = defineCommand({
   meta: { name: 'serve', description: 'Start the HTTP API server' },
   args: {
     port: { type: 'string', description: 'Port to listen on (or PORT env)' },
-    connectorsFromCommandMap: {
-      type: 'string',
-      description: 'Explicit connector command mappings (JSON object or @file)',
-    },
-    noConnectorsFromPath: {
-      type: 'boolean',
-      default: false,
-      description: 'Disable PATH-based connector discovery',
-    },
-    connectorsFromNpm: {
-      type: 'boolean',
-      default: false,
-      description: 'Enable npm auto-download of connectors (disabled by default)',
-    },
+    ...connectorArgs,
   },
   async run({ args }) {
     serveAction({
@@ -36,8 +42,42 @@ const serveCmd = defineCommand({
   },
 })
 
+/**
+ * Pre-parse connector discovery flags from process.argv so the resolver
+ * is configured before the one-shot CLI commands (check, read, etc.) run.
+ */
+function parseConnectorFlags(): {
+  connectorsFromPath: boolean
+  connectorsFromNpm: boolean
+  connectorsFromCommandMap?: string
+} {
+  const argv = process.argv
+  const noPath = argv.includes('--no-connectors-from-path')
+  const npm = argv.includes('--connectors-from-npm')
+  let commandMap: string | undefined
+  const cmdMapIdx = argv.indexOf('--connectors-from-command-map')
+  if (cmdMapIdx !== -1 && cmdMapIdx + 1 < argv.length) {
+    commandMap = argv[cmdMapIdx + 1]
+  }
+  return {
+    connectorsFromPath: !noPath,
+    connectorsFromNpm: npm,
+    connectorsFromCommandMap: commandMap,
+  }
+}
+
 export async function createProgram() {
-  const resolver = createConnectorResolver({})
+  const flags = parseConnectorFlags()
+  const resolver = createConnectorResolver(
+    {},
+    {
+      path: flags.connectorsFromPath,
+      npm: flags.connectorsFromNpm,
+      commandMap: parseJsonOrFile(flags.connectorsFromCommandMap) as
+        | Record<string, string>
+        | undefined,
+    }
+  )
   const app = createApp(resolver)
   const res = await app.request('/openapi.json')
   const spec = await res.json()
@@ -48,6 +88,7 @@ export async function createProgram() {
     exclude: ['health'],
     ndjsonBodyStream: () =>
       process.stdin.isTTY ? null : (Readable.toWeb(process.stdin) as ReadableStream),
+    rootArgs: connectorArgs,
     meta: {
       name: 'sync-engine',
       description: 'Stripe Sync Engine — sync Stripe data to Postgres',

e2e/connector-loading.test.sh

@@ -105,14 +105,16 @@ echo ""
 # Helpers
 # ---------------------------------------------------------------------------
 
+# JSON-encoded X-Sync-Params header value for check requests.
+SYNC_PARAMS='{"source_name":"stripe","source_config":{"api_key":"sk_test_fake"},"destination_name":"postgres","destination_config":{"connection_string":"postgresql://fake:fake@localhost/fake"},"streams":[{"name":"products"}]}'
+
 # Run `sync-engine check` with fake credentials and given extra flags.
 # Exits non-zero (bad credentials) but must NOT output "not found".
 # Usage: check_loads [extra flags...]
 check_loads() {
   local output
   output=$(npx sync-engine check \
-    --stripe-api-key sk_test_fake \
-    --postgres-url "postgresql://fake:fake@localhost/fake" \
+    --x-sync-params "$SYNC_PARAMS" \
     "$@" 2>&1 || true)
   if echo "$output" | grep -qi "not found"; then
     echo "  FAIL: got 'not found' — connector loading failed"
@@ -125,8 +127,7 @@ check_loads() {
 check_not_found() {
   local output
   output=$(npx sync-engine check \
-    --stripe-api-key sk_test_fake \
-    --postgres-url "postgresql://fake:fake@localhost/fake" \
+    --x-sync-params "$SYNC_PARAMS" \
     "$@" 2>&1 || true)
   if echo "$output" | grep -qi "not found"; then
     return 0