custom billing plan skippable messages#387
Merged
Merged
Conversation
mattmueller-stripe
changed the title
There was a problem hiding this comment.
Pull request overview
Adds additional Stripe “custom billing plan” error message patterns to the list of known skippable list errors, so affected streams are marked as skip (instead of failing) when these permanent 400s occur.
Changes:
- Add two new skippable Stripe error-message substrings for
billing_alertsandbilling_credit_grantscustom-plan limitations. - Extend the existing parameterized test coverage to assert
stream_status: skipis emitted for these errors. - Minor whitespace-only cleanup on an existing
concurrencycomment line.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/source-stripe/src/src-list-api.ts | Adds new skippable error-message patterns for custom-plan billing endpoints; no functional changes elsewhere beyond message matching. |
| packages/source-stripe/src/index.test.ts | Adds new test cases ensuring these custom-plan errors produce stream_status with skip. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
liouh-stripe
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
How to test (optional)
Related