Skip to content

Commit 4d52c83

Browse files
committed
Refactor comma key value text to strings.xml
1 parent f438353 commit 4d52c83

6 files changed

Lines changed: 11 additions & 8 deletions

File tree

app/src/main/res/values/strings.xml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,9 @@
3131
<string name="file_name__about_html">about.html</string>
3232
<!-- Backspace: U+232B ERASE TO THE LEFT -->
3333
<string name="display_text__backspace" translatable="false">⌫</string>
34+
<!-- Comma: U+002C COMMA, U+FF0C FULLWIDTH COMMA -->
35+
<string name="value_text__qwerty_comma" translatable="false">,</string>
36+
<string name="value_text__strokes_comma" translatable="false">,</string>
3437
<!-- Space bar: U+25C0, U+25B6 (triangles) -->
3538
<string name="display_text__qwerty_space_bar">◀ English ▶</string>
3639
<string name="display_text__strokes_space_bar">◀ Chinese ▶</string>

app/src/main/res/xml/keyboard_qwerty.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@
102102
/>
103103
<!-- Comma -->
104104
<Key
105-
app:keyValueText=","
105+
app:keyValueText="@string/value_text__qwerty_comma"
106106
app:keyWidth="@dimen/key_width__digit"
107107
/>
108108
<!-- Space bar -->

app/src/main/res/xml/keyboard_qwerty_symbols.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@
8282
/>
8383
<!-- Comma -->
8484
<Key
85-
app:keyValueText=","
85+
app:keyValueText="@string/value_text__qwerty_comma"
8686
app:keyWidth="@dimen/key_width__digit"
8787
/>
8888
<!-- Space bar -->

app/src/main/res/xml/keyboard_strokes.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,9 +91,9 @@
9191
app:keyTextOffsetY="@dimen/baseline_correction__switch_key"
9292
app:keyIsPreviewable="false"
9393
/>
94-
<!-- U+FF0C FULLWIDTH COMMA -->
94+
<!-- Comma -->
9595
<Key
96-
app:keyValueText=""
96+
app:keyValueText="@string/value_text__strokes_comma"
9797
app:keyWidth="@dimen/key_width__digit"
9898
/>
9999
<!-- Space bar -->

app/src/main/res/xml/keyboard_strokes_symbols_1.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -86,9 +86,9 @@
8686
app:keyTextOffsetY="@dimen/baseline_correction__switch_key"
8787
app:keyIsPreviewable="false"
8888
/>
89-
<!-- U+FF0C FULLWIDTH COMMA -->
89+
<!-- Comma -->
9090
<Key
91-
app:keyValueText=""
91+
app:keyValueText="@string/value_text__strokes_comma"
9292
app:keyWidth="@dimen/key_width__digit"
9393
/>
9494
<!-- Space bar -->

app/src/main/res/xml/keyboard_strokes_symbols_2.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,9 +63,9 @@
6363
app:keyTextOffsetY="@dimen/baseline_correction__switch_key"
6464
app:keyIsPreviewable="false"
6565
/>
66-
<!-- U+FF0C FULLWIDTH COMMA -->
66+
<!-- Comma -->
6767
<Key
68-
app:keyValueText=""
68+
app:keyValueText="@string/value_text__strokes_comma"
6969
app:keyWidth="@dimen/key_width__digit"
7070
/>
7171
<!-- Space bar -->

0 commit comments

Comments
 (0)