Skip to content

Repair struphy-install action#140

Merged
spossann merged 13 commits into
develfrom
workflow-struphy-install
Nov 27, 2025
Merged

Repair struphy-install action#140
spossann merged 13 commits into
develfrom
workflow-struphy-install

Conversation

@spossann

@spossann spossann commented Nov 24, 2025

Copy link
Copy Markdown
Member
  • do not use venv in struphy-install action; prepare Python env instead
  • try to make MacOS workflow actually do something
  • clean up PR tests
  • run PR tests on scheduled week-end pipeline

@spossann

Copy link
Copy Markdown
Member Author

The MacOs workflow now works: https://github.com/struphy-hub/struphy/actions/workflows/macos-latest.yml

@spossann spossann marked this pull request as ready for review November 26, 2025 20:41
@spossann spossann requested a review from max-models November 26, 2025 20:41
@max-models

Copy link
Copy Markdown
Member

So you want to skip the MPI tests in the push workflow? Is that really a good idea? They seem to be so fast anyway after the last PR

@spossann

Copy link
Copy Markdown
Member Author

So you want to skip the MPI tests in the push workflow? Is that really a good idea? They seem to be so fast anyway after the last PR

They are not skipped, as I did not eliminate them from the PR workflows. I commented the non-MPI tests from the weekend pipeline (reusable-testing), just for now, maybe we add them back later.

@max-models

Copy link
Copy Markdown
Member

So you want to skip the MPI tests in the push workflow? Is that really a good idea? They seem to be so fast anyway after the last PR

They are not skipped, as I did not eliminate them from the PR workflows. I commented the non-MPI tests from the weekend pipeline (reusable-testing), just for now, maybe we add them back later.

Oh, I see that now. I misunderstood this when reviewing on my phone

@spossann spossann merged commit 0046acd into devel Nov 27, 2025
8 checks passed
@spossann spossann deleted the workflow-struphy-install branch November 27, 2025 09:28
max-models pushed a commit that referenced this pull request Mar 20, 2026
* do not use venv in `struphy-install` action; prepare Python env
instead
* try to make MacOS workflow actually do something
* clean up PR tests
* run PR tests on scheduled week-end pipeline
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants