Modification of toy drift#224
Merged
Merged
Conversation
…entation of the base_units system, and added the possibility to modulate the alpha parameter in the toy_drift model method __init__
…lation, modification of the calculation of the growth rate
…rd loading parameter
Member
|
Hi @emilegrivet - you can request a review from me for this PR ;) |
spossann
approved these changes
May 13, 2026
spossann
added a commit
that referenced
this pull request
Jun 9, 2026
**Solves the following issue(s):** - Update of the loading random function used to sobol_standard (instead of pseudo_random) to minimize asymmetries. - Implementation of the coefficient alpha in the model toy_drift - optimization of the parameters used in the diocotron instability simulation to fit the results from Crouseilles_2014 paper. **Core changes:** None **Model-specific changes:** None **Documentation changes:** None --------- Co-authored-by: Max Lindqvist <max.lindqvist@ipp.mpg.de> Co-authored-by: Stefan Possanner <stefan.possanner@ipp.mpg.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves the following issue(s):
Core changes:
None
Model-specific changes:
None
Documentation changes:
None