fix: address copilot

Author: dupdob

src/Stryker.Core/Stryker.Core/Initialisation/InputFileResolver.cs

@@ -371,7 +371,6 @@ private IAnalyzerResults AnalyzeSingleProject(ProjectAnalyzerContext project, IS
                 buildResult = project.Analyze(forceFramework: true);
                 buildResultOverallSuccess = project.HasValidResults();
             }
-
         }
 
         if (options.DiagMode || _logger.IsEnabled(LogLevel.Debug))

src/Stryker.Core/Stryker.Core/Initialisation/ProjectAnalyzerContext.cs

@@ -6,7 +6,6 @@
 using Buildalyzer;
 using Buildalyzer.Environment;
 using Microsoft.Extensions.Logging;
-using Stryker.Abstractions.Exceptions;
 using Stryker.Utilities.Buildalyzer;
 
 namespace Stryker.Core.Initialisation;
@@ -116,52 +115,6 @@ private void InitializeTargetFrameworks()
 
     public IEnumerable<string> GetProjectReferences() => AnalyzerLastResults?.SelectMany(r => r.ProjectReferences).Distinct();
 
-    public IAnalyzerResult SelectAnalyzerResult()
-    {
-        var validResults = AnalyzerLastResults.ToList();
-        if (validResults.Count == 0)
-        {
-            throw new InputException($"No valid project analysis results could be found for '{ProjectFileName}'.");
-        }
-
-        if (_framework is null)
-        {
-            // we try to avoid desktop versions
-            return PickFrameworkVersion();
-        }
-
-        var resultForRequestedFramework = validResults.Find(a => a.TargetFramework == _framework);
-        if (resultForRequestedFramework is not null)
-        {
-            return resultForRequestedFramework;
-        }
-        // if there is only one available framework version, we log an info
-        if (validResults.Count == 1)
-        {
-            var singleAnalyzerResult = validResults[0];
-            _logger.LogInformation(
-                "Could not find a valid analysis for target {0} for project '{1}'. Selected version is {2}.",
-                _framework, ProjectFileName, singleAnalyzerResult.TargetFramework);
-            return singleAnalyzerResult;
-        }
-
-        var firstAnalyzerResult = PickFrameworkVersion();
-        var availableFrameworks = validResults.Select(a => a.TargetFramework).Distinct();
-        _logger.LogWarning(
-            """
-            Could not find a valid analysis for target {0} for project '{1}'.
-            The available target frameworks are: {2}.
-                 selected version is {3}.
-            """, _framework, ProjectFileName, string.Join(',', availableFrameworks), firstAnalyzerResult.TargetFramework);
-
-        return firstAnalyzerResult;
-
-        IAnalyzerResult PickFrameworkVersion()
-        {
-            return validResults.Find(a => a.IsValid() && !a.TargetsFullFramework()) ?? validResults[0];
-        }
-    }
-
     private static readonly HashSet<string> ImportantProperties =
         ["Configuration", "Platform", "AssemblyName", "Configurations", "TargetPath", "OS"];
 
@@ -236,7 +189,7 @@ private void DumpTestAnalyzerResult(StringBuilder log, IAnalyzerResult analyzerR
 
     public bool BuildsAnAssembly() => AnalyzerLastResults?.Any(p => p.BuildsAnAssembly()) == true;
 
-    public bool FindMatchingVariant(string assemblyPath, out IAnalyzerResult analyzerResult)
+    public bool FindMatchingVariant(string assemblyPath, out IAnalyzerResult? analyzerResult)
     {
         if (AnalyzerLastResults == null)
         {

src/Stryker.Solutions.Test/SolutionFileShould.cs

@@ -45,7 +45,7 @@ public void DetectPlatformIfNotSpecified(string platform)
         // Arrange
         List<string> projects = ["Project.csproj", "Test.csproj"];
         // Act
-        var solution = SolutionFile.BuildFromProjectList( projects, [platform]);
+        var solution = SolutionFile.BuildFromProjectList( projects, [platform], [platform]);
 
         // Assert
         solution.GetProjectsWithDetails("Debug").ShouldBe(projects.Select(p => (p, "Debug", platform)));

src/Stryker.Solutions/SolutionFile.cs

@@ -173,7 +173,7 @@ private string GetEffectiveBuildType(string? buildType)
     /// <param name="configuration">requested configuration</param>
     /// <param name="platform">requested platform</param>
     /// <returns></returns>
-    public (string configuration, string platform) GetProjectConfiguration(string filename, string configuration, string platform)
+    public (string configuration, string platform) GetProjectConfiguration(string filename, string? configuration, string? platform)
     {
         configuration = GetEffectiveBuildType(configuration);
         platform ??= DefaultPlatform;
@@ -189,30 +189,59 @@ private string GetEffectiveBuildType(string? buildType)
     /// </summary>
     /// <param name="projects">list of csproj filenames</param>
     /// <param name="platforms">list of declared platforms. Default to AnyCpu and x86</param>
+    /// <param name="solutionPlatforms">list of solution level platforms</param>
     /// <returns>a solution instance</returns>
     /// <remarks>This method is used for testing purposes. It is mandatory as the underlying solution parser does not support any form of mocking</remarks>
-    public static SolutionFile BuildFromProjectList(List<string> projects, string[]? platforms = null)
+    public static SolutionFile BuildFromProjectList(List<string> projects, string[]? platforms = null
+        , string[]? solutionPlatforms = null)
     {
         var result = new SolutionFile();
+        solutionPlatforms = DefineSolutionPlatforms(platforms, solutionPlatforms);
         platforms ??= [ "AnyCPU", "x86" ];
+        if (platforms.Length != solutionPlatforms.Length)
+        {
+            throw new ArgumentException("The number of platforms should be the same as the number of solution platforms, if specified.");
+        }
         // default to Debug|Any CPU
         string[] buildTypes = ["Debug", "Release"];
         foreach (var buildType in buildTypes)
         {
-            foreach (var platform in platforms)
+            for (var index = 0; index < platforms.Length; index++)
             {
+                var platform = platforms[index];
                 var projectDict = new Dictionary<string, (string buildType, string platform)>();
                 foreach (var project in projects)
                 {
                     projectDict[project] = (buildType, platform);
                 }
-                var solutionPlatform = platform == "AnyCPU" ? "Any CPU" : platform;
-                result._configurations.Add((buildType, solutionPlatform), projectDict);
+
+                result._configurations.Add((buildType, solutionPlatforms[index]), projectDict);
             }
         }
         return result;
     }
 
+    private static string[] DefineSolutionPlatforms(string[]? platforms, string[]? solutionPlatforms)
+    {
+        if (solutionPlatforms == null)
+        {
+            if (platforms == null)
+            {
+                solutionPlatforms = [ "Any CPU", "x86" ];
+            }
+            else
+            {
+                solutionPlatforms = new string[platforms.Length];
+                for (var i = 0; i < platforms.Length; i++)
+                {
+                    solutionPlatforms[i] = platforms[i] == DefaultProjectBuildType ? DefaultSolutionType : platforms[i];
+                }
+            }
+        }
+
+        return solutionPlatforms;
+    }
+
     private static SolutionFile AnalyzeSolution(string solutionPath, SolutionModel solution)
     {
         // extract needed information