fix: enhance device handling in MiniBrew sensor integration#17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request addresses issues with handling
Deviceobjects returned by the API in the MiniBrew Home Assistant integration, ensuring that both dictionary and object representations are processed correctly. The main changes improve robustness and compatibility when interacting with device data, preventing errors when the API returnsDeviceinstances instead of dictionaries.Device data handling improvements:
_device_to_dicthelper function insensor.pyto consistently convertDeviceobjects or other representations into dictionaries for reliable attribute access.sensor.pywhere device data is accessed (e.g., when checking theserial_number) to use_device_to_dict, ensuring compatibility with both dicts andDeviceobjects. [1] [2] [3] [4] [5]Bug fix:
Deviceobjects without setup errors, as noted in the changelog.