feat: update typeography#145
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
trying to fix my stuff without obsessing
For this I wanted to:
Not being a designer, I tried a few type scales out to see if i can get close to passable. Eventually settling on utopia for the scaling type as the others made my type look huge on mobile.
I tried a few type combos out but eventually settled on just Lora, it works really well and i like the simplicity of a single typeface.
Overall I think it looks ok? I don't know i get blind after a while. I want to look at a few other things, colour and adding some more elements to decorate it up a bit more but I'm not hugely bothered about that for now. Primary concern is getting it good enough i don't feel as embarrased sharing it