Skip to content

Commit b00fc1c

Browse files
study8677claude
andcommitted
fix: harden review challenges and unify findings consistency
- 007: replace version-dependent finding with deterministic blockers - 013: add ClosedPoolError hierarchy evidence to source excerpt - 017: remove answer-revealing hints from background and comments - 019: unify empty dual_coef_ shape contract across files - refresh metadata analysis/scoringHints across all 20 challenges - add challenge coverage matrix doc Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
1 parent dc2a7df commit b00fc1c

44 files changed

Lines changed: 667 additions & 421 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

challenges/review/001-sympy-point2d-ai-patch/metadata.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,8 +42,8 @@
4242
},
4343
"reviewTarget": {
4444
"file": "ai-pr.diff",
45-
"kind": "adapted-ai-plausible-patch",
46-
"note": "The reviewed patch is an AgentCode adapted patch for review training. It is not the upstream maintainer patch unless explicitly stated."
45+
"kind": "adapted-for-review",
46+
"note": "Adapted from a real upstream issue for review training. Whether this change should be merged is the question — reach your own conclusion before opening the source links."
4747
},
4848
"pr": {
4949
"title": "Fix Point raising 'Imaginary coordinates are not permitted' with evaluate(False)",

challenges/review/002-next-middleware-header-bypass/metadata.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,8 @@
4444
},
4545
"reviewTarget": {
4646
"file": "ai-pr.diff",
47-
"kind": "adapted-ai-plausible-patch",
48-
"note": "The reviewed patch is an AgentCode adapted plausible-but-incorrect patch for review training. It is not the upstream maintainer patch unless explicitly stated."
47+
"kind": "adapted-for-review",
48+
"note": "Adapted from a real upstream issue for review training. Whether this change should be merged is the question — reach your own conclusion before opening the source links."
4949
},
5050
"pr": {
5151
"title": "Skip auth middleware for internal framework subrequests to prevent redundant re-execution",

challenges/review/003-next-server-actions-ssrf/metadata.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,8 @@
4444
},
4545
"reviewTarget": {
4646
"file": "ai-pr.diff",
47-
"kind": "adapted-ai-plausible-patch",
48-
"note": "The reviewed patch is an AgentCode adapted plausible-but-incorrect patch for review training. It is not the upstream maintainer patch unless explicitly stated."
47+
"kind": "adapted-for-review",
48+
"note": "Adapted from a real upstream issue for review training. Whether this change should be merged is the question — reach your own conclusion before opening the source links."
4949
},
5050
"pr": {
5151
"title": "Support relative post-login redirects instead of only the configured origin",

challenges/review/004-axios-baseurl-absolute-url/README.en.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# Review 004: Axios — harden the internal API client against protocol-relative URL bypass
1+
# Review 004: Axios — add request URL validation to the internal API client
22

33
You are a reviewer on this repository. An AI agent submitted the PR below. CI is green and the decision is yours.
44

challenges/review/004-axios-baseurl-absolute-url/README.zh.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# Review 004:Axios:加固内部 API client,拦截 protocol-relative URL 绕过 baseURL
1+
# Review 004:Axios:给内部 API client 增加请求 URL 校验
22

33
你是这个仓库的 reviewer。一个 AI agent 提交了下面这个 PR,CI 全绿,等待你的结论。
44

challenges/review/004-axios-baseurl-absolute-url/metadata.json

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -6,19 +6,18 @@
66
"difficulty": "senior",
77
"status": "ready",
88
"title": {
9-
"zh": "Axios:加固内部 API client,拦截 protocol-relative URL 绕过 baseURL",
10-
"en": "Axios: harden the internal API client against protocol-relative URL bypass"
9+
"zh": "Axios:给内部 API client 增加请求 URL 校验",
10+
"en": "Axios: add request URL validation to the internal API client"
1111
},
1212
"summary": {
13-
"zh": "审查一个安全加固补丁:作者给带 Authorization 的 internal API client 增加校验,拒绝以 // 开头的 protocol-relative URL,防止它们绕过 baseURL",
14-
"en": "Review a security hardening patch that rejects protocol-relative (//) URLs on an Authorization-bearing internal API client so they cannot bypass baseURL."
13+
"zh": "审查一个给带 Authorization 的 internal API client 增加 URL 校验的补丁:作者拒绝以 // 开头的 protocol-relative URL。",
14+
"en": "Review a patch that adds URL validation to an internal API client carrying an Authorization header: it rejects protocol-relative URLs starting with //."
1515
},
1616
"language": "TypeScript / Axios",
1717
"tags": [
1818
"axios",
1919
"security",
20-
"ssrf",
21-
"credential-leak",
20+
"http-client",
2221
"url-parsing"
2322
],
2423
"source": {
@@ -45,8 +44,8 @@
4544
},
4645
"reviewTarget": {
4746
"file": "ai-pr.diff",
48-
"kind": "adapted-ai-plausible-patch",
49-
"note": "The reviewed patch is an AgentCode adapted plausible-but-incorrect patch for review training. It is not the upstream maintainer patch unless explicitly stated."
47+
"kind": "adapted-for-review",
48+
"note": "Adapted from a real upstream issue for review training. Whether this change should be merged is the question — reach your own conclusion before opening the source links."
5049
},
5150
"pr": {
5251
"title": "Reject protocol-relative URLs on internalApi to prevent baseURL bypass",

challenges/review/005-path-to-regexp-redos/metadata.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,8 @@
4545
},
4646
"reviewTarget": {
4747
"file": "ai-pr.diff",
48-
"kind": "adapted-ai-plausible-patch",
49-
"note": "The reviewed patch is an AgentCode adapted patch for review training. It is not the upstream maintainer patch unless explicitly stated."
48+
"kind": "adapted-for-review",
49+
"note": "Adapted from a real upstream issue for review training. Whether this change should be merged is the question — reach your own conclusion before opening the source links."
5050
},
5151
"pr": {
5252
"title": "Fix ReDoS in route compilation for adjacent parameters (GHSA-9wv6-86v2-598j)",

challenges/review/006-tough-cookie-prototype-pollution/metadata.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,8 @@
4545
},
4646
"reviewTarget": {
4747
"file": "ai-pr.diff",
48-
"kind": "adapted-ai-plausible-patch",
49-
"note": "The reviewed patch is an AgentCode adapted patch for review training. It is not the upstream maintainer patch unless explicitly stated."
48+
"kind": "adapted-for-review",
49+
"note": "Adapted from a real upstream issue for review training. Whether this change should be merged is the question — reach your own conclusion before opening the source links."
5050
},
5151
"pr": {
5252
"title": "Reject __proto__ cookie domain to fix prototype pollution (GHSA-72xf-g2v4-qvf3)",

challenges/review/007-jsonwebtoken-algorithm-pinning/README.en.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ Testing:
3737
## Background
3838

3939
- verifySession is the server-side entry point for validating session Bearer tokens: it takes a JWT, hands it to jsonwebtoken's jwt.verify to check the signature and issuer/audience, and returns the payload on success.
40-
- The production signing key, public-key path, and related settings come from environment configuration read at process startup.
40+
- The production signing key, public-key path, accepted algorithms, and related settings come from environment configuration read at process startup. Missing required auth configuration should fail closed before request handling.
4141

4242
## Answers and analysis
4343

challenges/review/007-jsonwebtoken-algorithm-pinning/README.zh.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ Testing:
3737
## 背景
3838

3939
- verifySession 是服务端校验会话 Bearer 令牌的入口:拿到 JWT,交给 jsonwebtoken 的 jwt.verify 校验签名和 issuer/audience,通过后返回 payload。
40-
- 生产环境的签名密钥、公钥路径等都来自环境配置,在进程启动时读取。
40+
- 生产环境的签名密钥、公钥路径、允许算法等都来自环境配置,在进程启动时读取。认证必需配置缺失时应在请求处理前 fail closed
4141

4242
## 答案与解析
4343

0 commit comments

Comments
 (0)