Skip to content

Commit 366d3b6

Browse files
committed
Avoid compile-time config for api_url
1 parent cdab0ac commit 366d3b6

2 files changed

Lines changed: 5 additions & 3 deletions

File tree

lib/segment/client/http.ex

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,6 @@ defmodule Segment.Http do
4040
require Logger
4141
use Retry
4242

43-
@segment_api_url Application.get_env(:segment, :api_url, "https://api.segment.io/v1/")
44-
4543
@doc """
4644
Create a Tesla client with the Segment Source Write API Key
4745
"""
@@ -66,7 +64,7 @@ defmodule Segment.Http do
6664
@spec client(String.t(), adapter()) :: client()
6765
def client(api_key, adapter) do
6866
middleware = [
69-
{Tesla.Middleware.BaseUrl, @segment_api_url},
67+
{Tesla.Middleware.BaseUrl, Segment.Config.api_url()},
7068
Tesla.Middleware.JSON,
7169
{Tesla.Middleware.BasicAuth, %{username: api_key, password: ""}}
7270
]

lib/segment/config.ex

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
11
defmodule Segment.Config do
22
@moduledoc false
33

4+
def api_url do
5+
Application.get_env(:segment, :api_url, "https://api.segment.io/v1/")
6+
end
7+
48
def service do
59
Application.get_env(:segment, :sender_impl, Segment.Analytics.Batcher)
610
end

0 commit comments

Comments
 (0)