Skip to content

Commit 97642b1

Browse files
stuggiclaude
andcommitted
Bump Go to 1.26.3
- Go: 1.24.4 -> 1.26.3 - operator-sdk: v1.41.1 -> v1.42.3 - golangci-lint: v2.7.2 -> v2.12.2 - GOTOOLCHAIN_VERSION: go1.24.0 -> go1.26.0 - go-toolset image: 1.24 -> 1.26 - .ci-operator.yaml: ci-build-root-golang-1.24-sdk-1.41.1 -> ci-build-root-golang-1.26-sdk-1.42.3 - ginkgo: v2.28.2 -> v2.32.0 - gomega: v1.42.0 -> v1.42.1 - gophercloud: v2.8.0 -> v2.13.0 - golang.org/x/exp: bumped to latest Also no longer depend on the rabbitmq cluster-operator, removing dead replace in go.mod. Jira: OSPRH-30997 Depends-On: openstack-k8s-operators/lib-common#715 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
1 parent c1f90b3 commit 97642b1

13 files changed

Lines changed: 98 additions & 99 deletions

.ci-operator.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
build_root_image:
22
name: tools
33
namespace: openstack-k8s-operators
4-
tag: ci-build-root-golang-1.24-sdk-1.41.1
4+
tag: ci-build-root-golang-1.26-sdk-1.42.3

.github/workflows/build-nova-operator.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@ jobs:
1616
uses: openstack-k8s-operators/openstack-k8s-operators-ci/.github/workflows/reusable-build-operator.yaml@main
1717
with:
1818
operator_name: nova
19-
go_version: 1.24.x
20-
operator_sdk_version: 1.41.1
19+
go_version: 1.26.x
20+
operator_sdk_version: 1.42.3
2121
secrets:
2222
IMAGENAMESPACE: ${{ secrets.IMAGENAMESPACE }}
2323
QUAY_USERNAME: ${{ secrets.QUAY_USERNAME }}

.github/workflows/build-operator-dont-publish.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,9 @@ jobs:
1212

1313
steps:
1414
- name: Install Go
15-
uses: actions/setup-go@bfdd3570ce990073878bf10f6b2d79082de49492 # v2
15+
uses: actions/setup-go@924ae3a1cded613372ab5595356fb5720e22ba16 # v6
1616
with:
17-
go-version: 1.21.x
17+
go-version: 1.26.x
1818

1919
- name: Checkout nova-operator repository
2020
uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 # v3

.github/workflows/force-bump-pr-manual.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,6 @@ jobs:
99
with:
1010
operator_name: nova
1111
branch_name: ${{ github.ref_name }}
12-
custom_image: quay.io/openstack-k8s-operators/openstack-k8s-operators-ci-build-tools:golang-1.24-sdk-1.41.1
12+
custom_image: quay.io/openstack-k8s-operators/openstack-k8s-operators-ci-build-tools:golang-1.26-sdk-1.42.3
1313
secrets:
1414
FORCE_BUMP_PULL_REQUEST_PAT: ${{ secrets.FORCE_BUMP_PULL_REQUEST_PAT }}

.github/workflows/force-bump-pr-scheduled.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,6 @@ jobs:
1010
uses: openstack-k8s-operators/openstack-k8s-operators-ci/.github/workflows/force-bump-branches.yaml@main
1111
with:
1212
operator_name: nova
13-
custom_image: quay.io/openstack-k8s-operators/openstack-k8s-operators-ci-build-tools:golang-1.24-sdk-1.41.1
13+
custom_image: quay.io/openstack-k8s-operators/openstack-k8s-operators-ci-build-tools:golang-1.26-sdk-1.42.3
1414
secrets:
1515
FORCE_BUMP_PULL_REQUEST_PAT: ${{ secrets.FORCE_BUMP_PULL_REQUEST_PAT }}

.golangci.yaml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,11 @@ linters:
1111
- gosec
1212
- errname
1313
- err113
14+
settings:
15+
govet:
16+
disable:
17+
# TODO: re-enable once golangci-lint supports Go 1.26 inlining of generics
18+
- inline
1419

1520
formatters:
1621
enable:

.pre-commit-config.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ repos:
8484
exclude: '\.sum$'
8585

8686
- repo: https://github.com/golangci/golangci-lint
87-
rev: v2.7.2
87+
rev: v2.12.2
8888
hooks:
8989
- id: golangci-lint-full
9090
args: ["-v"]

Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
ARG GOLANG_BUILDER=registry.access.redhat.com/ubi9/go-toolset:1.24
1+
ARG GOLANG_BUILDER=registry.access.redhat.com/ubi9/go-toolset:1.26
22
ARG OPERATOR_BASE_IMAGE=registry.access.redhat.com/ubi9/ubi-minimal:latest
33

44
# Build the manager binary

Makefile

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ endif
4848

4949
# Set the Operator SDK version to use. By default, what is installed on the system is used.
5050
# This is useful for CI or a project to utilize a specific version of the operator-sdk toolkit.
51-
OPERATOR_SDK_VERSION ?= v1.41.1
51+
OPERATOR_SDK_VERSION ?= v1.42.3
5252

5353
# Image URL to use all building/pushing image targets
5454
DEFAULT_IMG ?= quay.io/openstack-k8s-operators/nova-operator:latest
@@ -71,7 +71,7 @@ endif
7171
SHELL = /usr/bin/env bash -o pipefail
7272
.SHELLFLAGS = -ec
7373

74-
GOTOOLCHAIN_VERSION ?= go1.24.0
74+
GOTOOLCHAIN_VERSION ?= go1.26.0
7575

7676
.PHONY: all
7777
all: build
@@ -137,11 +137,11 @@ tidy: ## Run go mod tidy on every mod file in the repo
137137
go mod tidy
138138
cd ./api && go mod tidy
139139

140-
GOLANGCI_LINT_VERSION ?= v2.7.2
140+
GOLANGCI_LINT_VERSION ?= v2.12.2
141141
.PHONY: golangci-lint
142142
golangci-lint:
143143
# NOTE this will install golangci-lint in to local bin dir
144-
test -s $(LOCALBIN)/golangci-lint || curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s $(GOLANGCI_LINT_VERSION)
144+
test -s $(LOCALBIN)/golangci-lint || curl -sSfL https://golangci-lint.run/install.sh | sh -s $(GOLANGCI_LINT_VERSION)
145145
$(LOCALBIN)/golangci-lint run --fix
146146

147147
PROCS?=$(shell expr $(shell nproc --ignore 2) / 2)

api/go.mod

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
module github.com/openstack-k8s-operators/nova-operator/api
22

3-
go 1.24.4
3+
go 1.26.3
44

55
require (
66
github.com/google/go-cmp v0.7.0
77
github.com/openstack-k8s-operators/infra-operator/apis v0.6.1-0.20260629124631-33e3b7eda748
8-
github.com/openstack-k8s-operators/lib-common/modules/common v0.6.1-0.20260626101608-0959e9d46047
8+
github.com/openstack-k8s-operators/lib-common/modules/common v0.6.1-0.20260713090837-13a3b65580c3
99
github.com/robfig/cron/v3 v3.0.1
1010
k8s.io/api v0.31.14
1111
k8s.io/apimachinery v0.31.14
@@ -48,12 +48,12 @@ require (
4848
github.com/x448/float16 v0.8.4 // indirect
4949
go.yaml.in/yaml/v2 v2.4.2 // indirect
5050
go.yaml.in/yaml/v3 v3.0.4 // indirect
51-
golang.org/x/exp v0.0.0-20241217172543-b2144cdd0a67 // indirect
52-
golang.org/x/net v0.49.0 // indirect
51+
golang.org/x/exp v0.0.0-20260611194520-c48552f49976 // indirect
52+
golang.org/x/net v0.56.0 // indirect
5353
golang.org/x/oauth2 v0.30.0 // indirect
54-
golang.org/x/sys v0.41.0 // indirect
55-
golang.org/x/term v0.40.0 // indirect
56-
golang.org/x/text v0.34.0 // indirect
54+
golang.org/x/sys v0.46.0 // indirect
55+
golang.org/x/term v0.44.0 // indirect
56+
golang.org/x/text v0.38.0 // indirect
5757
golang.org/x/time v0.12.0 // indirect
5858
gomodules.xyz/jsonpatch/v2 v2.5.0 // indirect
5959
google.golang.org/protobuf v1.36.7 // indirect
@@ -90,7 +90,4 @@ replace k8s.io/code-generator => k8s.io/code-generator v0.31.14 //allow-merging
9090

9191
replace k8s.io/component-base => k8s.io/component-base v0.31.14 //allow-merging
9292

93-
// custom RabbitmqClusterSpecCore for OpenStackControlplane (v2.16.0_patches)
94-
replace github.com/rabbitmq/cluster-operator/v2 => github.com/openstack-k8s-operators/rabbitmq-cluster-operator/v2 v2.6.1-0.20250929174222-a0d328fa4dec //allow-merging
95-
9693
replace k8s.io/kube-openapi => k8s.io/kube-openapi v0.0.0-20250627150254-e9823e99808e //allow-merging

0 commit comments

Comments
 (0)