Optimize envtest for slow CI runs

With recent changes to the CI env we hit issues running envtest
hitting timeouts in test since 25s was not enough, but also
during kube-api startup and register custom CRDs before checks
start and teardown of the kube-api. Therefore adding
ControlPlaneStartTimeout and ControlPlaneStopTimeout bumping the
default 60s to 120s.

Also hitting slow env and with the 400+ tests, we have seen that
the default cluster ip range /24 is to small, increasing to /12

Also disable not required admission plugins for envtest:
ResourceQuota: This stops the "quota evaluation timed out" error.
The API server will no longer try to calculate how many resources
exist before letting you create new ones.

ServiceAccount: This prevents the API server from looking for a
ServiceAccount issuer or secret for every pod/resource. Since
envtest doesn't run the ServiceAccount controller, this plugin
often just causes unnecessary errors or delays.

NamespaceLifecycle: (Optional but recommended) This allows you to
create resources in a namespace even if the namespace is in a
"Terminating" state. This is very helpful when your cleanup is
slow due to CPU throttling.

Signed-off-by: Martin Schuppert <mschuppert@redhat.com>

Author: stuggi

test/functional/base_test.go

@@ -43,7 +43,7 @@ import (
 const (
 	SecretName     = "external-secret"
 	ContainerImage = "test://nova"
-	timeout        = 25 * time.Second
+	timeout        = 45 * time.Second
 	// have maximum 100 retries before the timeout hits
 	interval = timeout / 100
 	// consistencyTimeout is the amount of time we use to repeatedly check

test/functional/suite_test.go

@@ -127,6 +127,10 @@ var _ = BeforeSuite(func() {
 			keystoneCRDs,
 			rabbitCRDs,
 		},
+		// Increase this to 60 or 120 seconds for the single-core run
+		ControlPlaneStartTimeout: 120 * time.Second,
+		// Give it plenty of time to wind down (e.g., 60-120 seconds)
+		ControlPlaneStopTimeout: 120 * time.Second,
 		CRDInstallOptions: envtest.CRDInstallOptions{
 			Paths: []string{
 				networkv1CRD,
@@ -140,6 +144,14 @@ var _ = BeforeSuite(func() {
 			// failing on the colons in ::1
 			LocalServingHost: "127.0.0.1",
 		},
+		ControlPlane: envtest.ControlPlane{
+			APIServer: &envtest.APIServer{
+				Args: []string{
+					"--service-cluster-ip-range=10.0.0.0/12", // 65k+ IPs
+					"--disable-admission-plugins=ResourceQuota,ServiceAccount,NamespaceLifecycle",
+				},
+			},
+		},
 	}
 
 	// cfg is defined in this file globally.