Skip to content

Commit ae42c89

Browse files
Merge pull request openstack-k8s-operators#396 from abays/br_label_secrets
[b/r] Add backup labels to auto-generated secrets
2 parents 0565bc4 + 27fd741 commit ae42c89

1 file changed

Lines changed: 12 additions & 4 deletions

File tree

internal/openstackbaremetalset/baremetalhost.go

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ import (
99
"strings"
1010

1111
metal3v1 "github.com/metal3-io/baremetal-operator/apis/metal3.io/v1alpha1"
12+
"github.com/openstack-k8s-operators/lib-common/modules/common/backup"
1213
"github.com/openstack-k8s-operators/lib-common/modules/common/env"
1314
"github.com/openstack-k8s-operators/lib-common/modules/common/helper"
1415
"github.com/openstack-k8s-operators/lib-common/modules/common/labels"
@@ -71,7 +72,11 @@ func BaremetalHostProvision(
7172
templateParameters["CloudUserName"] = instance.Spec.CloudUserName
7273

7374
// Prepare cloudinit (create secret)
74-
secretLabels := labels.GetLabels(instance, labels.GetGroupLabel(baremetalv1.ServiceName), map[string]string{})
75+
backupLabels := util.MergeStringMaps(
76+
backup.GetBackupLabels(backup.CategoryDataPlane),
77+
backup.GetRestoreLabels(backup.RestoreOrder10, backup.CategoryDataPlane),
78+
)
79+
secretLabels := labels.GetLabels(instance, labels.GetGroupLabel(baremetalv1.ServiceName), backupLabels)
7580
if passwordSecret != nil && len(passwordSecret.Data["NodeRootPassword"]) > 0 {
7681
templateParameters["NodeRootPassword"] = string(passwordSecret.Data["NodeRootPassword"])
7782
}
@@ -152,9 +157,12 @@ func BaremetalHostProvision(
152157
networkDataSecretName := fmt.Sprintf(CloudInitNetworkDataSecretName, instance.Name, hostName)
153158

154159
// Flag the network data secret as safe to collect with must-gather
155-
secretLabelsWithMustGather := labels.GetLabels(instance, labels.GetGroupLabel(baremetalv1.ServiceName), map[string]string{
156-
MustGatherSecret: "yes",
157-
})
160+
networkDataLabels := util.MergeStringMaps(
161+
map[string]string{MustGatherSecret: "yes"},
162+
backup.GetBackupLabels(backup.CategoryDataPlane),
163+
backup.GetRestoreLabels(backup.RestoreOrder10, backup.CategoryDataPlane),
164+
)
165+
secretLabelsWithMustGather := labels.GetLabels(instance, labels.GetGroupLabel(baremetalv1.ServiceName), networkDataLabels)
158166

159167
networkDataSt := util.Template{
160168
Name: networkDataSecretName,

0 commit comments

Comments
 (0)