Fix ReconcileVersion re-creating OpenStackVersion during deletion

When an OpenStackControlPlane CR is deleted, the reconciler called
ReconcileVersion() before checking DeletionTimestamp. ReconcileVersion
unconditionally called CreateOrPatch on the OpenStackVersion CR,
which would re-create it even during deletion.

This caused issues in adoption CI: the pcp_cleanup role deleted the
OpenStackControlPlane but the controller re-created the OpenStackVersion
before fully shutting down. The leftover OpenStackVersion (named
'controlplane' from the source cloud) then caused the new
OpenStackControlPlane (named 'openstack') to be rejected by the
webhook with:

  OpenStackControlPlane 'openstack' must have same name as the
  existing 'controlplane' OpenStackVersion

Fix ReconcileVersion to properly handle the Get result:
- Return actual errors (not IsNotFound) instead of swallowing them
- Skip CreateOrPatch when the controlplane is being deleted
- Still return the existing version object so reconcileDelete can
  remove its finalizer

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: stuggi

internal/openstack/version.go

@@ -9,6 +9,7 @@ import (
 
 	"github.com/openstack-k8s-operators/lib-common/modules/common/helper"
 	corev1beta1 "github.com/openstack-k8s-operators/openstack-operator/api/core/v1beta1"
+	k8s_errors "k8s.io/apimachinery/pkg/api/errors"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/types"
 	ctrl "sigs.k8s.io/controller-runtime"
@@ -244,15 +245,24 @@ func ReconcileVersion(ctx context.Context, instance *corev1beta1.OpenStackContro
 
 	Log := GetLogger(ctx)
 
-	// return if OpenStackVersion CR already exists
 	if err := helper.GetClient().Get(ctx, types.NamespacedName{
 		Name:      instance.Name,
 		Namespace: instance.Namespace,
-	},
-		version); err == nil {
-		Log.Info(fmt.Sprintf("OpenStackVersion found. Name: %s", version.Name))
-	} else {
+	}, version); err != nil {
+		if !k8s_errors.IsNotFound(err) {
+			return ctrl.Result{}, nil, err
+		}
+		// OpenStackVersion not found, only create it if we're not being deleted
+		if !instance.DeletionTimestamp.IsZero() {
+			return ctrl.Result{}, version, nil
+		}
 		Log.Info(fmt.Sprintf("OpenStackVersion does not exist. Creating: %s", version.Name))
+	} else {
+		Log.Info(fmt.Sprintf("OpenStackVersion found. Name: %s", version.Name))
+		// Already exists, nothing to do if we're being deleted
+		if !instance.DeletionTimestamp.IsZero() {
+			return ctrl.Result{}, version, nil
+		}
 	}
 
 	op, err := controllerutil.CreateOrPatch(ctx, helper.GetClient(), version, func() error {