Fix OpenStackVersion minor update workflow hanging on OVN dataplane check

During a minor update, the OpenStackVersion controller was getting stuck
with incorrect condition states even after deployments completed:
- MinorUpdateOVNDataplane: "in progress" (stuck)
- MinorUpdateControlplane: "not started" (never executed)

Root Cause:
The DataplaneNodesetsOVNControllerImagesMatch function checked
nodeset.IsReady(), which failed when subsequent deployments
(e.g., edpm-update) started running. This caused the function to
return false even though the OVN update deployment (edpm-ovn-update)
had already completed successfully.

The nodeset's overall Ready status was False because edpm-update was
running, blocking the minor update workflow from progressing to the
next steps (RabbitMQ, MariaDB, controlplane services, etc.).

Solution:
Remove the nodeset.IsReady() check from DataplaneNodesetsOVNControllerImagesMatch.
The nodeset's Status.ContainerImages["OvnControllerImage"] is only updated
when a deployment completes successfully (openstackdataplanenodeset_controller.go:598-600).
Therefore, if the OVN image matches the target version, the OVN update
deployment has already completed, regardless of the nodeset's overall Ready status.

Why we can't check deployment-specific conditions:
The nodeset stores deployment conditions in Status.DeploymentStatuses map,
keyed by deployment name (e.g., "edpm-ovn-update"). However, deployment
names are dynamic and not known at this point in the code, making it
impossible to check specific deployment conditions directly.

Note: The final DataplaneNodesetsDeployed check still uses nodeset.IsReady()
because it validates the completion of the entire minor update workflow,
where we do want to ensure the nodeset is fully ready.

Jira: OSPRH-25860

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Signed-off-by: Martin Schuppert <mschuppert@redhat.com>

Author: stuggi

internal/openstack/dataplane.go

@@ -45,9 +45,16 @@ func DataplaneNodesetsOVNControllerImagesMatch(version *corev1beta1.OpenStackVer
 		// the current nodeset spec), we only check nodesets if they have any nodes
 		// and have deployed OVN
 		if len(nodeset.Spec.Nodes) > 0 && nodeset.Status.ContainerImages["OvnControllerImage"] != "" {
-			if !nodeset.IsReady() {
-				return false
-			}
+			// Check if OVN controller image matches the target version.
+			// Note: We don't check nodeset.IsReady() here because this is an intermediate
+			// step in the minor update workflow. The nodeset's Status.ContainerImages is only
+			// updated when a deployment completes successfully (see openstackdataplanenodeset_controller.go:598-600).
+			// The nodeset might be not-Ready due to subsequent deployments running (e.g., edpm-update),
+			// but if the OVN image matches, it means the OVN update deployment already completed.
+			//
+			// We cannot check the specific deployment condition (e.g., DeploymentStatuses["edpm-ovn-update"])
+			// because the deployment name is dynamic and not known at this point. The DeploymentStatuses
+			// map uses the actual deployment name as the key, which varies based on the deployment CR name.
 			if nodeset.Status.ContainerImages["OvnControllerImage"] != *version.Status.ContainerImages.OvnControllerImage {
 				return false
 			}