[b/r] Use Deployments instead of bare Pods for PVC pinning

Deployments auto-restart pods if evicted, which is important during
manual restore procedures where there may be a longer gap between
creating the dummy consumers and running the PVC restore.

Also removes debug tasks from playbook and keeps playbook and manual
docs in sync for validation.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: stuggi

docs/dev/backup-restore/restore/README.md

@@ -223,10 +223,12 @@ done
 #   mysql-db-openstack-galera-1:master-1
 #   mysql-db-openstack-galera-2:master-2
 
-# 3. Create dummy pods BEFORE the PVC restore.
+# 3. Create dummy Deployments BEFORE the PVC restore.
 #    Pods referencing non-existent PVCs stay Pending until the restore creates
 #    the PVCs. The scheduler then annotates the PVC with the selected node,
 #    triggering WaitForFirstConsumer binding on the target node.
+#    Using Deployments (not bare Pods) ensures automatic restart if a pod
+#    gets evicted during longer manual procedures.
 #    IMPORTANT: Use nodeSelector (not nodeName) so the pod goes through the
 #    scheduler — nodeName bypasses it and the PVC annotation never gets set.
 for pvc_node in \
@@ -241,26 +243,39 @@ for pvc_node in \
   node="${pvc_node##*:}"
 
   cat <<EOF | oc apply -f -
-apiVersion: v1
-kind: Pod
+apiVersion: apps/v1
+kind: Deployment
 metadata:
   name: pvc-pin-${pvc}
   namespace: openstack
   labels:
     app: pvc-pin
 spec:
-  nodeSelector:
-    kubernetes.io/hostname: ${node}
-  containers:
-  - name: pause
-    image: registry.k8s.io/pause:3.9
-    volumeMounts:
-    - name: data
-      mountPath: /data
-  volumes:
-  - name: data
-    persistentVolumeClaim:
-      claimName: ${pvc}
+  replicas: 1
+  strategy:
+    type: Recreate
+  selector:
+    matchLabels:
+      app: pvc-pin
+      pvc: ${pvc}
+  template:
+    metadata:
+      labels:
+        app: pvc-pin
+        pvc: ${pvc}
+    spec:
+      nodeSelector:
+        kubernetes.io/hostname: ${node}
+      containers:
+      - name: pause
+        image: registry.k8s.io/pause:3.9
+        volumeMounts:
+        - name: data
+          mountPath: /data
+      volumes:
+      - name: data
+        persistentVolumeClaim:
+          claimName: ${pvc}
 EOF
 done
 
@@ -275,8 +290,8 @@ oc apply -f 01-restore-order-00-pvcs.yaml
 # 6. Monitor progress
 oc get datadownload -n openshift-adp -w
 
-# 7. After all DataDownloads complete, delete dummy pods
-oc delete pods -n openstack -l app=pvc-pin
+# 7. After all DataDownloads complete, delete dummy Deployments
+oc delete deployment -n openstack -l app=pvc-pin
 ```
 
 **Alternative: Immediate StorageClass.** If you don't need to control which node

docs/dev/backup-restore/restore/restore-openstack.yaml

@@ -227,31 +227,44 @@
         msg: "{{ pvc_node_mapping.stdout_lines }}"
       when: pin_pvcs | bool and pvc_node_mapping.stdout != ""
 
-    - name: Create dummy pods to pin PVCs to nodes
+    - name: Create dummy Deployments to pin PVCs to nodes
       ansible.builtin.shell: |
         PVC_NAME="{{ item.split(':')[0] }}"
         NODE_NAME="{{ item.split(':')[1] }}"
         cat <<EOF | oc apply -f -
-        apiVersion: v1
-        kind: Pod
+        apiVersion: apps/v1
+        kind: Deployment
         metadata:
           name: pvc-pin-${PVC_NAME}
           namespace: {{ openstack_namespace }}
           labels:
             app: pvc-pin
         spec:
-          nodeSelector:
-            kubernetes.io/hostname: ${NODE_NAME}
-          containers:
-          - name: pause
-            image: registry.k8s.io/pause:3.9
-            volumeMounts:
-            - name: data
-              mountPath: /data
-          volumes:
-          - name: data
-            persistentVolumeClaim:
-              claimName: ${PVC_NAME}
+          replicas: 1
+          strategy:
+            type: Recreate
+          selector:
+            matchLabels:
+              app: pvc-pin
+              pvc: ${PVC_NAME}
+          template:
+            metadata:
+              labels:
+                app: pvc-pin
+                pvc: ${PVC_NAME}
+            spec:
+              nodeSelector:
+                kubernetes.io/hostname: ${NODE_NAME}
+              containers:
+              - name: pause
+                image: registry.k8s.io/pause:3.9
+                volumeMounts:
+                - name: data
+                  mountPath: /data
+              volumes:
+              - name: data
+                persistentVolumeClaim:
+                  claimName: ${PVC_NAME}
         EOF
         echo "Created pvc-pin-${PVC_NAME} on ${NODE_NAME}"
       loop: "{{ pvc_node_mapping.stdout_lines }}"
@@ -300,9 +313,9 @@
         restore_name: "openstack-restore-00-pvcs-{{ restore_suffix }}"
         step_name: "Step 1 (PVC restore)"
 
-    - name: Delete dummy pods after PVC restore
+    - name: Delete dummy Deployments after PVC restore
       ansible.builtin.shell: |
-        oc delete pods -n {{ openstack_namespace }} -l app=pvc-pin --ignore-not-found=true
+        oc delete deployment -n {{ openstack_namespace }} -l app=pvc-pin --ignore-not-found=true
       changed_when: true
       when: pin_pvcs | bool