Denys branch#4
Open
curlydevil wants to merge 3 commits into
Open
Conversation
- added ui-bootstrap to index.html - added heatmap module to index.html - removed dead code from app.js - adjusted highcharts-widget's files to visually accomplish task
- added chroma-js dependency into index.html - reordered dependencies a bit - fixed caption for highcharts widget - adjusted handsontable-widget's files to visually accomplish task
- added $element injection to widgets' controllers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added solution for the tasks, though not optimal - better approach would be to add directives for HTML-manipulation and just to pass data from widgets' controllers to them for data rendering, leaving color scheme selection etc. in widgets' controllers, but that would require more dev time, and I'm pretty sure that making this code perfect is not the target of the task.