Skip to content

#14 babel plugin source map support for styled and createGlobalStyle#180

Open
yiochen wants to merge 1 commit into
styled-components:mainfrom
yiochen:sourcemap
Open

#14 babel plugin source map support for styled and createGlobalStyle#180
yiochen wants to merge 1 commit into
styled-components:mainfrom
yiochen:sourcemap

Conversation

@yiochen

@yiochen yiochen commented Nov 25, 2018

Copy link
Copy Markdown

No description provided.

@yiochen yiochen changed the title #14 babel plugin source map support for style and createGlobalStyle #14 babel plugin source map support for styled and createGlobalStyle Nov 25, 2018
@matatablack

Copy link
Copy Markdown

Any updates on this? Thanks!

@Antho2407

Copy link
Copy Markdown

Any updates ?

@rusackas

rusackas commented Feb 5, 2020

Copy link
Copy Markdown

Wondering if this still works in 2020. If so, I could sure use some source maps right about now :)

@quantizor

quantizor commented Feb 5, 2020 via email

Copy link
Copy Markdown
Collaborator

@bradydowling

Copy link
Copy Markdown

@probablyup do you just mean resolving the merge conflicts or is there more to the "remake" than that?

@quantizor

Copy link
Copy Markdown
Collaborator

@bradydowling

  1. merge conflicts
  2. any corresponding changes due to v5 (the original styled-components-side PR was made against v4 I believe)

@shobhitsharma

Copy link
Copy Markdown

@mxstbr @probablyup Any updates on this?

@quantizor

Copy link
Copy Markdown
Collaborator

Thanks @yiochen. Source maps (#14) are still on the wishlist and the work in this PR is appreciated. The runtime side changed significantly with sc v5/v6, so any forward path here needs a refresh against current sc internals. Leaving open as the active source-map thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants