10.14 Build Target#198
Draft
jncn wants to merge 13 commits intosubethaedit:developfrom
Draft
Conversation
…into develop # Conflicts: # SubEthaEdit-Mac/Source/OpenURLViewController.h # SubEthaEdit-Mac/Source/OpenURLViewController.m # SubEthaEdit-Mac/SubEthaEdit.xcodeproj/project.pbxproj # SubEthaEdit-Mac/de.lproj/OpenURLViewController.xib
…into develop # Conflicts: # SubEthaEdit-Mac/Source/SEEWebPreviewViewController.m
Reduced warnings from 230+ to 48
jncn
commented
Dec 15, 2020
| [sharingServices removeObject:[NSSharingService sharingServiceNamed:NSSharingServiceNamePostOnTwitter]]; | ||
| [sharingServices removeObject:[NSSharingService sharingServiceNamed:NSSharingServiceNamePostOnSinaWeibo]]; | ||
| [sharingServices removeObject:[NSSharingService sharingServiceNamed:NSSharingServiceNamePostOnTencentWeibo]]; | ||
| [sharingServices removeObject:[NSSharingService sharingServiceNamed:NSSharingServiceNamePostOnLinkedIn]]; |
Collaborator
Author
There was a problem hiding this comment.
These are not just deprecated: from 10.14 these services are not longer present
Contributor
|
You still have your url changes in the change request - probably need to rebase/change your baseline to develop at some point in time ^^ |
…ndle version change, moved deployment target change to project level
…or the azure pipeline
…ild-target # Conflicts: # SubEthaEdit-Mac/Source/SEECollaborationPreferenceModule.m
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR for #197