fix install script to respect the chosen remote branch#203
Merged
Conversation
Member
|
Thanks, could you run shellcheck on the script and fix the lint warnings?
…On Fri, Apr 18, 2025, 4:41 PM Blaise Perennial ***@***.***> wrote:
@blaiseper <https://github.com/blaiseper> requested your review on: #203
<#203> fix
install script to respect the chosen remote branch.
—
Reply to this email directly, view it on GitHub
<#203 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACVUMSSJBDV57WIM25WOF322FPN5AVCNFSM6AAAAAB3NVZM2SVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJXGMZDINRVHEYDINQ>
.
You are receiving this because your review was requested.Message ID:
***@***.***
.com>
|
blaiseper
force-pushed
the
install-script-branch
branch
from
944ae4a to
311446b
Compare
Contributor
Author
|
@ab ready for re-review, ty |
ab
approved these changes
Apr 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like there's been a regression where the install script doesn't refer to
$remote_branchduring git clone anymore.This fixes that