Skip to content

Commit f0f6949

Browse files
[Test Rules] [PR #4515] modified rule: Service abuse: Trello board invitation with VIP impersonation
1 parent 7e7d430 commit f0f6949

1 file changed

Lines changed: 13 additions & 10 deletions

File tree

detection-rules/4515_service_abuse_trello_board_invite_vip.yml

Lines changed: 13 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -29,12 +29,14 @@ source: |
2929
// org vip
3030
any($org_vips,
3131
strings.icontains(..display_text, .display_name)
32-
or strings.icontains(..display_text,
33-
strings.concat(.first_name, " ", .last_name)
34-
)
3532
or strings.icontains(..display_text,
3633
strings.concat(.last_name, ", ", .first_name)
3734
)
35+
or any(regex.extract(.display_name,
36+
'\A(?P<name>.+?)\s*[\((][^))]*[))]\s*\z'
37+
),
38+
strings.icontains(...display_text, .named_groups["name"])
39+
)
3840
)
3941
// org sld as the board name
4042
and any($org_slds,
@@ -51,18 +53,19 @@ source: |
5153
and strings.iends_with(.display_text, 'From')
5254
and any($org_vips,
5355
strings.icontains(..display_text, .display_name)
54-
or strings.icontains(..display_text,
55-
strings.concat(.first_name,
56-
" ",
57-
.last_name
58-
)
59-
)
6056
or strings.icontains(..display_text,
6157
strings.concat(.last_name,
6258
", ",
6359
.first_name
6460
)
6561
)
62+
or any(regex.extract(.display_name,
63+
'\A(?P<name>.+?)\s*[\((][^))]*[))]\s*\z'
64+
),
65+
strings.icontains(...display_text,
66+
.named_groups["name"]
67+
)
68+
)
6669
)
6770
)
6871
)
@@ -79,4 +82,4 @@ detection_methods:
7982
id: "e42bdd9e-3872-5266-bf29-791ebfa714a7"
8083
og_id: "fedfc94b-4a33-57e0-a891-1af92aec6ddb"
8184
testing_pr: 4515
82-
testing_sha: 1658ad9fc984cdf4e2a8a85f6af83206ffd6dde1
85+
testing_sha: 3c7644f9963fb214445fd5add76ce8f949a4acf0

0 commit comments

Comments
 (0)