Skip to content

Add YARA rule compilation validation to CI #4357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aidenmitchell wants to merge 1 commit into
base: main
Choose a base branch
from
+18 −0
Open

Add YARA rule compilation validation to CI #4357

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions .github/workflows/rule-validate.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,24 @@ jobs:

echo "All batches submitted successfully!"

- name: Validate YARA rules
if: github.event_name != 'issue_comment'
run: |
sudo apt-get install -y -qq yara > /dev/null 2>&1
Copy link
Copy Markdown
Member

@cameron-dunn-sublime cameron-dunn-sublime Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Req: pin yara version

failed=0
for f in yara/*.yar; do
echo "Validating $f..."
if ! yarac "$f" /dev/null; then
Copy link
Copy Markdown
Member

@cameron-dunn-sublime cameron-dunn-sublime Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may produce different results than the parsing and validation we do within the platform. We can talk offline for more detail, but I know we've seen subtle differences between our validation in feeds vs. supported features in Strelka.

echo "::error file=$f::YARA rule failed to compile: $f"
failed=1
fi
done
if [[ $failed -eq 1 ]]; then
echo "One or more YARA rules failed to compile"
exit 1
fi
echo "All YARA rules compiled successfully!"

- name: Verify no .yaml files exist
if: github.event_name != 'issue_comment'
run: |
Expand Down
Loading