Skip to content

Add first_name/last_name concat matching to org_vips sender rules#4513

Open
IndiaAce wants to merge 8 commits into
sublime-security:mainfrom
IndiaAce:india.fn.na.org_vips_name_ordering_sender
Open

Add first_name/last_name concat matching to org_vips sender rules#4513
IndiaAce wants to merge 8 commits into
sublime-security:mainfrom
IndiaAce:india.fn.na.org_vips_name_ordering_sender

Conversation

@IndiaAce

Copy link
Copy Markdown
Member

Description

Add alternative name matching logic to org_vips sender-based rules to handle cases where
display_name is stored as "Lastname, Firstname" instead of "Firstname Lastname".
Uses strings.concat(.first_name, " ", .last_name) and strings.concat(.last_name, ", ", .first_name)
as additional or conditions inside existing any($org_vips, ...) blocks.

This is a test rule deployment to assess impact magnitude.

Affected rules

  • impersonation_vip_bec_loose.yml
  • vip_impersonation.yml
  • impersonation_vip_urgent_request.yml
  • impersonation_vip_invoicing_request.yml
  • impersonation_vip_w2_request.yml
  • sender_contains_org_vip.yml (insight)

Associated samples

N/A - validation only (no TP canonical available)

Associated hunts

TBD - will be run after test rule deployment

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@IndiaAce IndiaAce requested a review from a team May 20, 2026 16:49
@IndiaAce IndiaAce requested a review from a team as a code owner May 20, 2026 16:49
@github-actions github-actions Bot added the in-test-rules PR is in our testing suite to collect telemetry label May 20, 2026
github-actions Bot added a commit that referenced this pull request May 20, 2026
github-actions Bot added a commit that referenced this pull request May 20, 2026
github-actions Bot added a commit that referenced this pull request May 20, 2026
github-actions Bot added a commit that referenced this pull request May 20, 2026
github-actions Bot added a commit to IndiaAce/sublime-rules that referenced this pull request May 20, 2026
… with BEC language (near match, untrusted sender)
github-actions Bot added a commit to IndiaAce/sublime-rules that referenced this pull request May 20, 2026
github-actions Bot added a commit to IndiaAce/sublime-rules that referenced this pull request May 20, 2026
… with urgent request (strict match, untrusted sender)
github-actions Bot added a commit to IndiaAce/sublime-rules that referenced this pull request May 20, 2026
github-actions Bot added a commit to IndiaAce/sublime-rules that referenced this pull request May 20, 2026
github-actions Bot added a commit that referenced this pull request May 20, 2026
…with BEC language (near match, untrusted sender)
github-actions Bot added a commit that referenced this pull request May 20, 2026
github-actions Bot added a commit that referenced this pull request May 20, 2026
…with urgent request (strict match, untrusted sender)
github-actions Bot added a commit that referenced this pull request May 20, 2026
github-actions Bot added a commit that referenced this pull request May 20, 2026
Comment on lines 11 to 13
and not sender.email.domain.root_domain in $high_trust_sender_root_domains
and not sender.email.domain.root_domain in $org_domains
and headers.auth_summary.dmarc.pass

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are these inside the any($org_vips) check?

IndiaAce and others added 2 commits May 29, 2026 15:03
…al stripping, revert insights

- Remove redundant strings.concat(.first_name, " ", .last_name) checks (already covered by .display_name)
- Keep strings.concat(.last_name, ", ", .first_name) for orgs storing VIPs as "Doe, John"
- Add regex-based parenthetical stripping for VIP names like "Shelly Chaka (She/her/hers)"
- Fix == to =~ for concat checks in vip_impersonation and urgent_request rules
- Revert insights/sender/sender_contains_org_vip.yml to main state (out of scope)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
github-actions Bot added a commit that referenced this pull request May 29, 2026
github-actions Bot added a commit that referenced this pull request May 29, 2026
github-actions Bot added a commit that referenced this pull request May 29, 2026
github-actions Bot added a commit that referenced this pull request May 29, 2026
github-actions Bot added a commit that referenced this pull request May 29, 2026
github-actions Bot added a commit to IndiaAce/sublime-rules that referenced this pull request May 29, 2026
…ion with BEC language (near match, untrusted sender)
github-actions Bot added a commit to IndiaAce/sublime-rules that referenced this pull request May 29, 2026
github-actions Bot added a commit that referenced this pull request May 29, 2026
IndiaAce and others added 2 commits May 29, 2026 16:23
The concat(.first_name, " ", .last_name) check already handles parenthetical
display names because .first_name/.last_name are stored as clean values.
Also fixes == to =~ for concat checks in vip_impersonation and urgent_request.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
github-actions Bot added a commit to IndiaAce/sublime-rules that referenced this pull request May 29, 2026
…ion with BEC language (near match, untrusted sender)
github-actions Bot added a commit to IndiaAce/sublime-rules that referenced this pull request May 29, 2026
github-actions Bot added a commit to IndiaAce/sublime-rules that referenced this pull request May 29, 2026
…ion with urgent request (strict match, untrusted sender)
github-actions Bot added a commit to IndiaAce/sublime-rules that referenced this pull request May 29, 2026
…ion with w2 request with reply-to mismatch
github-actions Bot added a commit to IndiaAce/sublime-rules that referenced this pull request May 29, 2026
github-actions Bot added a commit that referenced this pull request May 29, 2026
…on with BEC language (near match, untrusted sender)
github-actions Bot added a commit that referenced this pull request May 29, 2026
github-actions Bot added a commit that referenced this pull request May 29, 2026
…on with urgent request (strict match, untrusted sender)
github-actions Bot added a commit that referenced this pull request May 29, 2026
github-actions Bot added a commit that referenced this pull request May 29, 2026
github-actions Bot added a commit that referenced this pull request May 29, 2026
github-actions Bot added a commit that referenced this pull request May 29, 2026
github-actions Bot added a commit that referenced this pull request May 29, 2026
github-actions Bot added a commit that referenced this pull request May 29, 2026
github-actions Bot added a commit that referenced this pull request May 29, 2026
github-actions Bot added a commit that referenced this pull request Jun 8, 2026
…on with BEC language (near match, untrusted sender)
github-actions Bot added a commit that referenced this pull request Jun 8, 2026
github-actions Bot added a commit that referenced this pull request Jun 8, 2026
…on with urgent request (strict match, untrusted sender)
github-actions Bot added a commit that referenced this pull request Jun 8, 2026
github-actions Bot added a commit that referenced this pull request Jun 8, 2026
github-actions Bot added a commit that referenced this pull request Jun 8, 2026
github-actions Bot added a commit that referenced this pull request Jun 8, 2026
github-actions Bot added a commit that referenced this pull request Jun 8, 2026
github-actions Bot added a commit that referenced this pull request Jun 8, 2026
github-actions Bot added a commit that referenced this pull request Jun 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in-test-rules PR is in our testing suite to collect telemetry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants