feat: add Physiological and Socioeconomic variable types#30
Open
clevinson wants to merge 2 commits into
Open
Conversation
Add DiscretePhysiologicalVariable and ContinuousPhysiologicalVariable under MeasuredVariable with MeasuredPhysiologicalFields mixin (biological subject, taxonomic ID, life stage, experimental design fields). Add SocioeconomicVariable under InSituVariable with study characterization fields (quantitative/qualitative, social study type, site characterization). No QC, instrument, or calibration fields. New enums: TaxonomicCodeSystem, LifeStage, QuantitativeQualitative, SocialStudyType. Add physiological and socioeconomic to VariableType enum. Update Variables docs page: mermaid diagram, type table, mapping table (also adds missing ContinuousCO2Variable), type-specific traits section with links to auto-generated mixin pages. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's how I've added these new variable types:
InSituVariable, so it has all those standard fields of the InSituVariable variable type (not a user-facing variable name, this is just one we use in the schema to group together all the Discrete and Measured variables).InSituVariablemeans that socioeconomic has the following optional fields:Some questions that came up along the way:
unitsis currently required for SocioeconomicVariable (also inherited from InSituVariable), is that OK?Let me know if you have any feedback or suggestions to change the above.
corresponding Metadata Builder PR is here: submarine-mrv/oae-metadata-builder#42