Commit 2148f7e
committed
fix(uddf): trim mixRef + order-independent tank lookup in test
Addresses Copilot review feedback on PR #253:
- tankdata mixRef is now trimmed before being stored as
uddfGasMixRef, so whitespace-only refs don't become
non-resolvable identifiers downstream.
- waypoint <switchmix ref> is trimmed and skipped when empty,
so gasSwitches entries the importer couldn't resolve to a
tank are never emitted.
- Integration test identifies tanks by o2Percent (32% bottom /
80% deco) instead of relying on SQLite/Drift row order,
removing cross-version flakiness.1 parent d6c042f commit 2148f7e
2 files changed
Lines changed: 21 additions & 13 deletions
File tree
- lib/core/services/export/uddf
- test/features/dive_import
Lines changed: 10 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1372 | 1372 | | |
1373 | 1373 | | |
1374 | 1374 | | |
1375 | | - | |
1376 | | - | |
| 1375 | + | |
| 1376 | + | |
| 1377 | + | |
1377 | 1378 | | |
1378 | 1379 | | |
1379 | 1380 | | |
1380 | | - | |
1381 | | - | |
1382 | | - | |
| 1381 | + | |
1383 | 1382 | | |
1384 | 1383 | | |
1385 | 1384 | | |
| |||
1576 | 1575 | | |
1577 | 1576 | | |
1578 | 1577 | | |
1579 | | - | |
1580 | | - | |
| 1578 | + | |
| 1579 | + | |
| 1580 | + | |
| 1581 | + | |
| 1582 | + | |
| 1583 | + | |
1581 | 1584 | | |
1582 | 1585 | | |
1583 | 1586 | | |
| |||
Lines changed: 11 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
166 | 166 | | |
167 | 167 | | |
168 | 168 | | |
169 | | - | |
170 | | - | |
171 | | - | |
172 | | - | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
173 | 176 | | |
174 | 177 | | |
175 | 178 | | |
176 | 179 | | |
177 | 180 | | |
178 | 181 | | |
179 | | - | |
| 182 | + | |
| 183 | + | |
180 | 184 | | |
181 | 185 | | |
182 | 186 | | |
183 | 187 | | |
184 | | - | |
| 188 | + | |
| 189 | + | |
185 | 190 | | |
186 | 191 | | |
187 | 192 | | |
| |||
0 commit comments