|
9 | 9 | **Tech Stack:** Flutter, Dart 3, `libdivecomputer_plugin` (local package at `packages/libdivecomputer_plugin/`), Riverpod, `flutter_test`. |
10 | 10 |
|
11 | 11 | **Dependencies:** |
12 | | -- PR for the Phase 1 spike (`feature/macdive-zsamples-phase-1`) must merge first (adds `docs/import-formats/macdive-zsamples.md` and the retained tooling). That branch targets `feature/macdive-sqlite`. |
13 | | -- PR #256 (`feature/macdive-sqlite`) must be open throughout so Phase 2 can target it. |
| 12 | +- PR #256 (MacDive SQLite import, `feature/macdive-sqlite`) is **merged** to `main` as of 2026-04-23. All reader/mapper files this plan modifies already live on `main`. |
| 13 | +- The Phase 1 spike PR (#260, `feature/macdive-zsamples-phase-1`) should merge before this work starts, so `docs/import-formats/macdive-zsamples.md` and the retained tooling are on `main`. Alternatively, this work can stack on top of `feature/macdive-zsamples-phase-1` — either target works. |
14 | 14 | - The `libdivecomputer` git submodule must be initialized in the worktree. |
15 | 15 |
|
16 | 16 | **Spec:** `docs/superpowers/specs/2026-04-23-macdive-sqlite-profile-decoding-design.md` (as updated with the Phase 1 outcome). |
@@ -62,10 +62,18 @@ If the API is workable, the rest of this plan applies. |
62 | 62 |
|
63 | 63 | **Files:** No files created. |
64 | 64 |
|
65 | | -- [ ] **Step 1: Create the Phase 2 worktree from the Phase 1 branch tip** |
| 65 | +- [ ] **Step 1: Create the Phase 2 worktree** |
66 | 66 |
|
| 67 | +After the Phase 1 PR (#260) merges to `main`, base off `main`: |
67 | 68 | ```bash |
68 | 69 | git fetch origin |
| 70 | +git worktree add -b feature/macdive-profile-zrawdata \ |
| 71 | + .worktrees/macdive-profile-zrawdata \ |
| 72 | + origin/main |
| 73 | +``` |
| 74 | + |
| 75 | +If Phase 1 PR is still open and you want to stack (and later rebase once #260 merges), base off its branch instead: |
| 76 | +```bash |
69 | 77 | git worktree add -b feature/macdive-profile-zrawdata \ |
70 | 78 | .worktrees/macdive-profile-zrawdata \ |
71 | 79 | origin/feature/macdive-zsamples-phase-1 |
@@ -481,10 +489,13 @@ git commit -m "test(macdive): gated real-sample test cross-validates ZRAWDATA vs |
481 | 489 | git push -u origin feature/macdive-profile-zrawdata |
482 | 490 | ``` |
483 | 491 |
|
484 | | -- [ ] **Step 2: Open PR against `feature/macdive-zsamples-phase-1`** (which in turn targets `feature/macdive-sqlite`). |
| 492 | +- [ ] **Step 2: Open PR** |
| 493 | + |
| 494 | +If Phase 1 PR (#260) has merged: target `main`. |
| 495 | +If Phase 1 PR is still open and you want to stack: target `feature/macdive-zsamples-phase-1`. |
485 | 496 |
|
486 | 497 | ```bash |
487 | | -gh pr create --base feature/macdive-zsamples-phase-1 \ |
| 498 | +gh pr create --base main \ |
488 | 499 | --title "MacDive profile decoding (Phase 2: ZRAWDATA via libdivecomputer)" \ |
489 | 500 | --body "$(cat <<'EOF' |
490 | 501 | ## Summary |
@@ -512,7 +523,7 @@ Decodes `ZDIVE.ZRAWDATA` through the already-integrated |
512 | 523 | confirm the depth-over-time chart renders. |
513 | 524 | - [ ] Gated real-sample test passes locally with the user's 6.7MB DB. |
514 | 525 |
|
515 | | -Stacked on: #256 → `feature/macdive-zsamples-phase-1` → this PR. |
| 526 | +Prior work: #256 (metadata import, merged) → #260 (Phase 1 spike, open) → this PR. |
516 | 527 | EOF |
517 | 528 | )" |
518 | 529 | ``` |
|
0 commit comments