Skip to content

Commit 484462f

Browse files
committed
docs(plan): Phase 2 plan references main as target (PR #256 merged)
1 parent 09bfe9c commit 484462f

1 file changed

Lines changed: 17 additions & 6 deletions

File tree

docs/superpowers/plans/2026-04-23-macdive-profile-phase-2-zrawdata.md

Lines changed: 17 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@
99
**Tech Stack:** Flutter, Dart 3, `libdivecomputer_plugin` (local package at `packages/libdivecomputer_plugin/`), Riverpod, `flutter_test`.
1010

1111
**Dependencies:**
12-
- PR for the Phase 1 spike (`feature/macdive-zsamples-phase-1`) must merge first (adds `docs/import-formats/macdive-zsamples.md` and the retained tooling). That branch targets `feature/macdive-sqlite`.
13-
- PR #256 (`feature/macdive-sqlite`) must be open throughout so Phase 2 can target it.
12+
- PR #256 (MacDive SQLite import, `feature/macdive-sqlite`) is **merged** to `main` as of 2026-04-23. All reader/mapper files this plan modifies already live on `main`.
13+
- The Phase 1 spike PR (#260, `feature/macdive-zsamples-phase-1`) should merge before this work starts, so `docs/import-formats/macdive-zsamples.md` and the retained tooling are on `main`. Alternatively, this work can stack on top of `feature/macdive-zsamples-phase-1` — either target works.
1414
- The `libdivecomputer` git submodule must be initialized in the worktree.
1515

1616
**Spec:** `docs/superpowers/specs/2026-04-23-macdive-sqlite-profile-decoding-design.md` (as updated with the Phase 1 outcome).
@@ -62,10 +62,18 @@ If the API is workable, the rest of this plan applies.
6262

6363
**Files:** No files created.
6464

65-
- [ ] **Step 1: Create the Phase 2 worktree from the Phase 1 branch tip**
65+
- [ ] **Step 1: Create the Phase 2 worktree**
6666

67+
After the Phase 1 PR (#260) merges to `main`, base off `main`:
6768
```bash
6869
git fetch origin
70+
git worktree add -b feature/macdive-profile-zrawdata \
71+
.worktrees/macdive-profile-zrawdata \
72+
origin/main
73+
```
74+
75+
If Phase 1 PR is still open and you want to stack (and later rebase once #260 merges), base off its branch instead:
76+
```bash
6977
git worktree add -b feature/macdive-profile-zrawdata \
7078
.worktrees/macdive-profile-zrawdata \
7179
origin/feature/macdive-zsamples-phase-1
@@ -481,10 +489,13 @@ git commit -m "test(macdive): gated real-sample test cross-validates ZRAWDATA vs
481489
git push -u origin feature/macdive-profile-zrawdata
482490
```
483491

484-
- [ ] **Step 2: Open PR against `feature/macdive-zsamples-phase-1`** (which in turn targets `feature/macdive-sqlite`).
492+
- [ ] **Step 2: Open PR**
493+
494+
If Phase 1 PR (#260) has merged: target `main`.
495+
If Phase 1 PR is still open and you want to stack: target `feature/macdive-zsamples-phase-1`.
485496

486497
```bash
487-
gh pr create --base feature/macdive-zsamples-phase-1 \
498+
gh pr create --base main \
488499
--title "MacDive profile decoding (Phase 2: ZRAWDATA via libdivecomputer)" \
489500
--body "$(cat <<'EOF'
490501
## Summary
@@ -512,7 +523,7 @@ Decodes `ZDIVE.ZRAWDATA` through the already-integrated
512523
confirm the depth-over-time chart renders.
513524
- [ ] Gated real-sample test passes locally with the user's 6.7MB DB.
514525
515-
Stacked on: #256 → `feature/macdive-zsamples-phase-1` → this PR.
526+
Prior work: #256 (metadata import, merged) → #260 (Phase 1 spike, open) → this PR.
516527
EOF
517528
)"
518529
```

0 commit comments

Comments
 (0)