chore: CHANGELOG and plan update for M3 completion

Author: ericgriffin

CHANGELOG.md

@@ -19,6 +19,15 @@ All notable changes to Submersion are documented in this file.
   internal units at the reader boundary.
 - **MacDive (XML) source override** in the import wizard's detected-source
   dropdown, alongside the existing MacDive (CSV) option.
+- **MacDive SQLite import.** Direct import from MacDive's Core Data
+  SQLite database — the most complete metadata path. Captures dives,
+  sites, buddies, tags (as with XML), gear inventory, critters/marine
+  life sightings, dive events, service records, and certifications.
+  Cross-format deduplication via source UUIDs: if you've already
+  imported the same dives via MacDive UDDF or XML, re-importing from
+  SQLite won't create duplicates.
+- **MacDive (SQLite) source override** in the import wizard's
+  detected-source dropdown, alongside MacDive (CSV) and MacDive (XML).
 
 ### Fixed
 
@@ -42,6 +51,15 @@ All notable changes to Submersion are documented in this file.
   parsed but not yet persisted to the profile samples table. A future
   milestone will wire them through, likely via the dive-events table.
 
+### Known limitations
+
+- Profile samples (depth/time-series data) are NOT imported from
+  MacDive SQLite. MacDive stores sample data in `ZDIVE.ZSAMPLES`
+  using a proprietary binary format that isn't publicly documented
+  and isn't standard bplist or any common compression. Users who
+  need time-series profile data should use the MacDive UDDF import
+  path instead, which decodes MacDive's UDDF profile correctly.
+
 
 ## 1.4.5 (2026-04-21)
 

docs/superpowers/plans/2026-04-21-macdive-sqlite-import.md

@@ -20,6 +20,41 @@
 
 ---
 
+## Milestone 3 Status — COMPLETE
+
+- All 14 tasks landed; bplist decoder (Tasks 1-4) shipped with UID
+  support after real-sample probing revealed NSKeyedArchiver format
+  in ZTIMEZONE.
+- ZSAMPLES profile-sample decoding **descoped** — MacDive uses a
+  proprietary binary format (entropy 7.85 bits/byte; not bplist; not
+  zlib/gzip/lzma at any reasonable offset). Users wanting profile
+  samples should use M1's UDDF import. M3 is the "rich metadata"
+  path; UDDF remains the "sample data" path.
+- New `ImportFormat.macdiveSqlite` + source override. Detector
+  chain: SQLite magic → Shearwater check → MacDive check → generic.
+- `MacDiveDbReader` validates schema (ZDIVE + ZDIVESITE + ZGAS +
+  ZTANKANDGAS) and returns typed row graph keyed by PK; junctions
+  as dive_pk → related_pks maps. Filters null-FK tombstones in
+  ZTANKANDGAS discovered on real data.
+- `MacDiveDiveMapper` reuses M2's `MacDiveUnitConverter` and
+  `MacDiveValueMapper`. Dive map keys match M2's `MacDiveXmlParser`
+  exactly so the same `UddfEntityImporter` downstream consumes
+  both sources uniformly.
+- `ImportDuplicateChecker` now short-circuits on `source_uuid`
+  when incoming dives match existing `dive_data_sources.source_uuid`.
+  Separate parameter map keeps the `Dive` entity unchanged
+  (multi-source-per-dive semantics preserved).
+- Gated `@Tags(['real-data'])` test asserts against user's real
+  6.7MB DB: 540 dives, 373 sites, 33 buddies, 39 tags, 32 gear —
+  all with sourceUuid populated. Profile always empty per descope.
+- Full test suite passes.
+
+Next: M4 (Photos) extends M2's XML parser and M3's SQLite reader
+to emit `imageRefs` on payloads and adds a photo-linking wizard
+step.
+
+---
+
 ## File Structure
 
 | File | Role | New / Modified |

test/features/universal_import/data/parsers/macdive_sqlite_parser_test.dart

@@ -25,13 +25,13 @@ void main() {
     });
 
     test('supportedFormats is macdiveSqlite', () {
-      expect(MacDiveSqliteParser().supportedFormats, [
+      expect(const MacDiveSqliteParser().supportedFormats, [
         ImportFormat.macdiveSqlite,
       ]);
     });
 
     test('parses synthetic MacDive SQLite end-to-end', () async {
-      final payload = await MacDiveSqliteParser().parse(validBytes);
+      final payload = await const MacDiveSqliteParser().parse(validBytes);
       expect(payload.entitiesOf(ImportEntityType.dives).length, 3);
       expect(payload.entitiesOf(ImportEntityType.sites).length, 2);
       expect(
@@ -56,15 +56,15 @@ void main() {
       db.dispose();
 
       final otherBytes = Uint8List.fromList(await tmp.readAsBytes());
-      final payload = await MacDiveSqliteParser().parse(otherBytes);
+      final payload = await const MacDiveSqliteParser().parse(otherBytes);
       expect(payload.isEmpty, isTrue);
       expect(payload.warnings, isNotEmpty);
       expect(payload.warnings.first.severity, ImportWarningSeverity.error);
     });
 
     test('returns error payload on totally invalid bytes', () async {
       final garbage = Uint8List.fromList(const [0, 1, 2, 3, 4]);
-      final payload = await MacDiveSqliteParser().parse(garbage);
+      final payload = await const MacDiveSqliteParser().parse(garbage);
       expect(payload.isEmpty, isTrue);
       expect(payload.warnings.first.severity, ImportWarningSeverity.error);
     });