Fix SAC date format#273
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
Happy to have Claude generate additional test coverage (here and/or in my other PR) if that's desired. The |
There was a problem hiding this comment.
Pull request overview
This PR fixes the SAC “best/worst” record date display in the gas statistics page so it honors the user’s configured date format. It does so by passing the underlying DateTime through UnitFormatter.formatDate(...) instead of hardcoding day/month/year.
Changes:
- Add a
datefield toRankingItemand populate it when fetching best/worst SAC record dives. - Update the gas statistics SAC record cards to format the record date via
UnitFormatter.formatDate(...).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| lib/features/statistics/presentation/pages/statistics_gas_page.dart | Uses UnitFormatter.formatDate(...) for best/worst SAC record subtitles. |
| lib/features/statistics/data/repositories/statistics_repository.dart | Extends RankingItem with a date field and sets it when mapping SAC record query results. |
c97fbf9 to
05da8ab
Compare
Summary
Closes #159
Changes
datefield to the RankingItem class & set it when retrieving best/worst SAC divesUnitFormatterto best/worst SAC dives when building the gas statistics pageTest Plan
flutter testpassesflutter analyzepassesScreenshots
Before:


After:

