Skip to content

i18n: use correct German umlauts#278

Merged
ericgriffin merged 1 commit into
submersion-app:mainfrom
readme42:german-umlauts
May 13, 2026
Merged

i18n: use correct German umlauts#278
ericgriffin merged 1 commit into
submersion-app:mainfrom
readme42:german-umlauts

Conversation

@readme42
Copy link
Copy Markdown
Contributor

Fixes #262

Summary

  • Replace ASCII substitutions with proper German characters across all 4 500+ strings in app_de.arb and the generated app_localizations_de.dart:
    • ae/oe/ue → ä/ö/ü
    • ss → ß where German orthography requires it (e.g. schließen, Größe, außerhalb, mäßig)
  • Preserves natural spellings in loanwords and proper nouns (aktuell, Bluetooth, Quelle, Rescue Diver, etc.)

Test Plan

  • flutter test passes
  • flutter analyze passes
  • Manual testing on: Windows

@codecov
Copy link
Copy Markdown

codecov Bot commented May 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copy link
Copy Markdown
Member

@ericgriffin ericgriffin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ericgriffin ericgriffin merged commit 7513048 into submersion-app:main May 13, 2026
14 checks passed
@github-project-automation github-project-automation Bot moved this from Backlog to Done in Submersion Release Tracker May 13, 2026
@readme42 readme42 deleted the german-umlauts branch May 13, 2026 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

German translations do not use umlauts (ä, ö, ü, ß)

2 participants