Skip to content

[external-secrets] SUDO-645: add support for 'dataFrom' secret extraction#270

Merged
jkruke merged 2 commits intomainfrom
SUDO-645-external-secrets-dataFrom
Apr 17, 2026
Merged

[external-secrets] SUDO-645: add support for 'dataFrom' secret extraction#270
jkruke merged 2 commits intomainfrom
SUDO-645-external-secrets-dataFrom

Conversation

@jkruke
Copy link
Copy Markdown
Contributor

@jkruke jkruke commented Apr 16, 2026

@jkruke jkruke changed the title [external-secrets] SUDO-645: add support for 'dataFrom' in external-secrets chart [external-secrets] SUDO-645: add support for 'dataFrom' secret extraction Apr 16, 2026
DanielRaapDev
DanielRaapDev previously approved these changes Apr 17, 2026
Copy link
Copy Markdown
Member

@DanielRaapDev DanielRaapDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@DanielRaapDev
Copy link
Copy Markdown
Member

DanielRaapDev commented Apr 17, 2026

docs is https://external-secrets.io/latest/guides/all-keys-one-secret/ ?!

datafrom.rewrite is not possible with the current patch. Maybe use a full datafrom block from the values?

@jkruke
Copy link
Copy Markdown
Contributor Author

jkruke commented Apr 17, 2026

docs is https://external-secrets.io/latest/guides/all-keys-one-secret/ ?!

datafrom.rewrite is not possible with the current patch. Maybe use a full datafrom block from the values?

Ah yeah your docs link is more suitable!
Changed to full dataFrom => fade2c5

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds Helm chart support for extracting multiple secret keys from a single JSON secret using External Secrets Operator spec.dataFrom.

Changes:

  • Extend ExternalSecret template to optionally render spec.dataFrom.
  • Add an example dataFrom.extract configuration to chart test values.
  • Bump chart version and update Artifact Hub changelog annotation.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
charts/external-secrets/templates/external_secret.yaml Render spec.dataFrom when configured (otherwise render spec.data).
charts/external-secrets/test-values.yaml Add a dataFrom-based example secret configuration.
charts/external-secrets/Chart.yaml Version bump + changelog entry for the new feature.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread charts/external-secrets/templates/external_secret.yaml
Comment thread charts/external-secrets/templates/external_secret.yaml
@jkruke jkruke merged commit a693445 into main Apr 17, 2026
6 checks passed
@jkruke jkruke deleted the SUDO-645-external-secrets-dataFrom branch April 17, 2026 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants