feat(isthmus)!: remove invalid SetOp to Calcite relation mappings

The Substrait -> Calcite converter mapped MINUS_MULTISET to Calcite
Minus(all=true) and INTERSECTION_PRIMARY to Intersect(all=false). These
mappings are incorrect: the spec behaviour of these set operations does
not match the Calcite relations they were mapped to. They were retained
temporarily to let users migrate off of them.

Neither MINUS_MULTISET nor INTERSECTION_PRIMARY has an equivalent Calcite
relation, so converting a plan containing either to Calcite now throws
UnsupportedOperationException.

BREAKING CHANGE: Converting a Substrait plan that uses the MINUS_MULTISET
or INTERSECTION_PRIMARY set operations to Calcite now throws
UnsupportedOperationException instead of producing an incorrect Calcite
relation. The supported set-difference operations are MINUS_PRIMARY
(Minus all=false) and MINUS_PRIMARY_ALL (Minus all=true); the supported
intersection operations are INTERSECTION_MULTISET (Intersect all=false)
and INTERSECTION_MULTISET_ALL (Intersect all=true).

Closes #303

Author: nielspardon

isthmus/src/main/java/io/substrait/isthmus/SubstraitRelNodeConverter.java

@@ -285,10 +285,6 @@ public RelNode visit(Set set, Context context) throws RuntimeException {
             input -> {
               relBuilder.push(input.accept(this, context));
             });
-    // TODO: MINUS_MULTISET and INTERSECTION_PRIMARY mappings are set to be removed as they do not
-    //   correspond to the Calcite relations they are associated with. They are retained for now
-    //   to enable users to migrate off of them.
-    //   See:  https://github.com/substrait-io/substrait-java/issues/303
     RelBuilder builder = getRelBuilder(set);
     RelNode node = builder.build();
     return applyRemap(node, set.getRemap());
@@ -301,9 +297,7 @@ private RelBuilder getRelBuilder(Set set) {
       case MINUS_PRIMARY:
         return relBuilder.minus(false, numInputs);
       case MINUS_PRIMARY_ALL:
-      case MINUS_MULTISET:
         return relBuilder.minus(true, numInputs);
-      case INTERSECTION_PRIMARY:
       case INTERSECTION_MULTISET:
         return relBuilder.intersect(false, numInputs);
       case INTERSECTION_MULTISET_ALL:

isthmus/src/test/java/io/substrait/isthmus/SubstraitRelNodeConverterTest.java

@@ -1,5 +1,7 @@
 package io.substrait.isthmus;
 
+import static org.junit.jupiter.api.Assertions.assertThrows;
+
 import io.substrait.plan.Plan;
 import io.substrait.relation.Join.JoinType;
 import io.substrait.relation.Rel;
@@ -242,6 +244,24 @@ void emit() {
       RelNode relNode = substraitToCalcite.convert(root.getInput());
       assertRowMatch(relNode.getRowType(), R.I32, N.STRING);
     }
+
+    // MINUS_MULTISET and INTERSECTION_PRIMARY have no equivalent Calcite relation, so converting
+    // them to Calcite is unsupported.
+    @Test
+    void minusMultisetUnsupported() {
+      Plan.Root root = sb.root(sb.set(SetOp.MINUS_MULTISET, commonTable, commonTable));
+
+      assertThrows(
+          UnsupportedOperationException.class, () -> substraitToCalcite.convert(root.getInput()));
+    }
+
+    @Test
+    void intersectionPrimaryUnsupported() {
+      Plan.Root root = sb.root(sb.set(SetOp.INTERSECTION_PRIMARY, commonTable, commonTable));
+
+      assertThrows(
+          UnsupportedOperationException.class, () -> substraitToCalcite.convert(root.getInput()));
+    }
   }
 
   @Nested

isthmus/src/test/java/io/substrait/isthmus/utils/SetUtils.java

@@ -59,7 +59,8 @@ private static String asString(Set.SetOp op) {
   }
 
   // Generate all SetOp types excluding:
-  // * MINUS_MULTISET, INTERSECTION_PRIMARY: do not map to Calcite relations
+  // * MINUS_MULTISET, INTERSECTION_PRIMARY: no equivalent Calcite relation, so they are
+  //   unsupported in Substrait -> Calcite conversion
   // * UNKNOWN: invalid
   public static Stream<Arguments> setTestConfig() {
     return Arrays.stream(Set.SetOp.values())