ci: run yamllint on pull requests (#971)

Author: nielspardon

.github/workflows/pr.yml

@@ -17,6 +17,17 @@ jobs:
           fetch-depth: 0
       - uses: editorconfig-checker/action-editorconfig-checker@v2
       - run: editorconfig-checker
+  yamllint:
+    name: Lint YAML
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v7
+      - uses: actions/setup-python@v6
+        with:
+          python-version: '3.14'
+      - uses: pre-commit/action@v3.0.1
+        with:
+          extra_args: yamllint --all-files
   security:
     name: Security validation
     runs-on: ubuntu-latest
@@ -115,9 +126,8 @@ jobs:
         ./isthmus-cli/src/test/script/smoke.sh
         ./isthmus-cli/src/test/script/tpch_smoke.sh
     - name: Rename the artifact to OS-unique name
-      shell: bash
-      run: |
-        value=`mv isthmus-cli/build/native/nativeCompile/isthmus isthmus-cli/build/native/nativeCompile/isthmus-${{ matrix.os }}`
+      working-directory: isthmus-cli/build/native/nativeCompile
+      run: mv isthmus isthmus-${{ matrix.os }}
     - name: Publish artifact
       uses: actions/upload-artifact@v7
       with:

.github/workflows/pr_title.yaml

@@ -45,6 +45,9 @@ jobs:
     permissions:
       pull-requests: write
     steps:
+      # The message below is prose inside the github-script template literal;
+      # wrapping it would change the rendered comment, so disable line-length here.
+      # yamllint disable rule:line-length
       - uses: actions/github-script@v9
         with:
           script: |
@@ -90,3 +93,4 @@ jobs:
             core.setFailed(
               "PR title and description do not follow the Conventional Commits specification."
             );
+      # yamllint enable rule:line-length

.github/workflows/release.yml

@@ -41,9 +41,8 @@ jobs:
           ./isthmus-cli/src/test/script/smoke.sh
           ./isthmus-cli/src/test/script/tpch_smoke.sh
       - name: Rename the artifact to OS-unique name
-        shell: bash
-        run: |
-          value=`mv isthmus-cli/build/native/nativeCompile/isthmus isthmus-cli/build/native/nativeCompile/isthmus-${{ matrix.os }}`
+        working-directory: isthmus-cli/build/native/nativeCompile
+        run: mv isthmus isthmus-${{ matrix.os }}
       - name: Publish artifact
         uses: actions/upload-artifact@v7
         with:
@@ -86,18 +85,21 @@ jobs:
         with:
           name: isthmus-macOS-latest
           path: native/libs
-      - name: Get bot user ID
+      - name: Get bot user ID and email
         id: bot-user-id
         run: |
-          echo "user-id=$(gh api "/users/${{ steps.app-token.outputs.app-slug }}[bot]" --jq .id)" >> "$GITHUB_OUTPUT"
+          slug="${{ steps.app-token.outputs.app-slug }}"
+          user_id="$(gh api "/users/${slug}[bot]" --jq .id)"
+          echo "user-id=${user_id}" >> "$GITHUB_OUTPUT"
+          echo "email=${user_id}+${slug}[bot]@users.noreply.github.com" >> "$GITHUB_OUTPUT"
         env:
           GITHUB_TOKEN: ${{ steps.app-token.outputs.token }}
       - name: Run semantic-release
         run: ./ci/release/run.sh
         env:
           GITHUB_TOKEN: ${{ steps.app-token.outputs.token }}
-          GIT_AUTHOR_EMAIL: "${{ steps.bot-user-id.outputs.user-id }}+${{ steps.app-token.outputs.app-slug }}[bot]@users.noreply.github.com"
-          GIT_COMMITTER_EMAIL: "${{ steps.bot-user-id.outputs.user-id }}+${{ steps.app-token.outputs.app-slug }}[bot]@users.noreply.github.com"
+          GIT_AUTHOR_EMAIL: ${{ steps.bot-user-id.outputs.email }}
+          GIT_COMMITTER_EMAIL: ${{ steps.bot-user-id.outputs.email }}
           SIGNING_KEY_ID: ${{ secrets.SIGNING_KEY_ID }}
           SIGNING_PASSWORD: ${{ secrets.SIGNING_PASSWORD }}
           SIGNING_KEY: ${{ secrets.SIGNING_KEY }}