Skip to content

build: fix Gradle warnings #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bestbeforetoday merged 1 commit into from
Aug 13, 2025
Merged

build: fix Gradle warnings #480

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion core/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,7 @@ abstract class SubstraitSpecVersionValueSource :
}

tasks.register("writeManifest") {
val version = project.version
doLast {
val substraitSpecVersionProvider =
providers.of(SubstraitSpecVersionValueSource::class) {
Expand All @@ -187,7 +188,7 @@ tasks.register("writeManifest") {
manifestFile.printWriter(StandardCharsets.UTF_8).use {
it.println("Manifest-Version: 1.0")
it.println("Implementation-Title: substrait-java")
it.println("Implementation-Version: " + project.version)
it.println("Implementation-Version: " + version)
it.println("Specification-Title: substrait")
it.println("Specification-Version: " + substraitSpecVersionProvider.get())
}
Expand Down
3 changes: 2 additions & 1 deletion isthmus-cli/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,7 @@ graal {
}

tasks.register("writeIsthmusVersion") {
val version = project.version
doLast {
val isthmusVersionClass =
layout.buildDirectory
Expand All @@ -155,7 +156,7 @@ tasks.register("writeIsthmusVersion") {
it.println("public class IsthmusCliVersion implements IVersionProvider {")
it.println(" public String[] getVersion() throws Exception {")
it.println(" return new String[] {")
it.println(" \"\${COMMAND-NAME} version " + project.version + "\",")
it.println(" \"\${COMMAND-NAME} version " + version + "\",")
it.println(" \"Substrait version \" + SubstraitVersion.VERSION,")
it.println("};")
it.println(" }")
Expand Down
Loading