chore(isthmus): alternate forms for tpc-ds queries#513
Merged
bestbeforetoday merged 1 commit intoSep 19, 2025
Conversation
bestbeforetoday
marked this pull request as ready for review
September 18, 2025 20:45
Alternate forms for TPC-DS queries 27, 36, 70 and 86. These forms rewrite queries that use the GROUPING aggregate function, which does not have a direct Substrait equivalent. These test cases now pass. Signed-off-by: Mark S. Lewis <Mark.S.Lewis@outlook.com>
bestbeforetoday
force-pushed
the
tpcds-grouping
branch
from
September 19, 2025 10:21
e8bc8f0 to
d50eac9
Compare
nielspardon
approved these changes
Sep 19, 2025
nielspardon
left a comment
nielspardon
left a comment
Member
There was a problem hiding this comment.
LGTM, I think it is good that we can cover these TPC-DS queries already in the alternate forms specified as part of the TPC-DS benchmark while we are still figuring out how to support the original format with the GROUPING / GROUPING_ID function syntax.
ZorinAnton
pushed a commit
to ZorinAnton/substrait-java
that referenced
this pull request
Sep 23, 2025
Alternate forms for TPC-DS queries 27, 36, 70 and 86. These forms rewrite queries that use the GROUPING aggregate function, which does not have a direct Substrait equivalent. These test cases now pass. Signed-off-by: Mark S. Lewis <Mark.S.Lewis@outlook.com>
This was referenced Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternate forms for TPC-DS queries 27, 36, 70 and 86. These forms rewrite queries that use the GROUPING aggregate function, which does not have a direct Substrait equivalent. These test cases now pass.