Skip to content

Commit 1b77d17

Browse files
nielspardonclaude
andauthored
test: fix consistent partition window test for urn-based extension API (#166)
## Summary The `main` CI is red because test collection fails on `tests/builders/plan/test_consistent_partition_window.py`, which cancels the whole test matrix. The test (added in #158) was written against the older `uri`-based extension API, but the codebase has since migrated to `urn`s. Two stale references remained: - `register_extension_dict(..., uri=...)`: the `uri` keyword no longer exists, causing a `TypeError` at collection time. The URN is now supplied via the `urn:` field already present in the test's YAML, so the kwarg is removed. - `extension_uris=list(lead_ee.extension_uris)`: this proto field was renamed to `extension_urns` (already present on the preceding line). This second error was masked by the collection failure. ## Test plan - `pytest tests/builders/plan/test_consistent_partition_window.py` -> 8 passed - Full suite -> 231 passed, 3 xfailed Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent cf4e04e commit 1b77d17

1 file changed

Lines changed: 1 addition & 4 deletions

File tree

tests/builders/plan/test_consistent_partition_window.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -54,9 +54,7 @@
5454
"""
5555

5656
registry = ExtensionRegistry(load_default_extensions=False)
57-
registry.register_extension_dict(
58-
yaml.safe_load(content), uri="https://test.example.com/test.yaml"
59-
)
57+
registry.register_extension_dict(yaml.safe_load(content))
6058

6159
struct = stt.Type.Struct(
6260
types=[i64(nullable=False), i16(nullable=False), i32(nullable=False)],
@@ -106,7 +104,6 @@ def test_consistent_partition_window_single():
106104
expected = stp.Plan(
107105
version=default_version,
108106
extension_urns=list(lead_ee.extension_urns),
109-
extension_uris=list(lead_ee.extension_uris),
110107
extensions=list(lead_ee.extensions),
111108
relations=[
112109
stp.PlanRel(

0 commit comments

Comments
 (0)