fix(tests): use correct compact table row format in std_dev and variance tests#1043
Merged
Merged
Conversation
benbellick
force-pushed
the
fix/std-dev-variance-compact-table-format
branch
from
April 10, 2026 20:42
a73fbb3 to
a45f0ee
Compare
benbellick
marked this pull request as ready for review
April 10, 2026 20:47
benbellick
requested review from
EpsilonPrime,
cpcloud,
jacques-n,
nielspardon,
vbarua,
westonpace and
yongchul
as code owners
April 10, 2026 20:47
yongchul
reviewed
Apr 10, 2026
…nce tests The compact aggregate test format uses each inner parenthesis group as a row, with literals inside representing column values for that row. The std_dev and variance test files were using a flat list of values in a single group, e.g. `((1.0, 2.0, 3.0))`, which parses as 1 row with 3 columns rather than 3 rows with 1 column. This changes them to the correct per-row format: `((1.0), (2.0), (3.0))`. See #1042 for a grammar improvement that would allow a cleaner inline format for these test cases. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
benbellick
force-pushed
the
fix/std-dev-variance-compact-table-format
branch
from
April 10, 2026 21:54
a45f0ee to
af9a681
Compare
nielspardon
approved these changes
Apr 13, 2026
nielspardon
left a comment
Member
There was a problem hiding this comment.
LGTM, thanks for catching this
yongchul
approved these changes
Apr 13, 2026
Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
benbellick
added a commit
to substrait-io/substrait-go
that referenced
this pull request
Apr 13, 2026
The single-column compact table format used in these test files was corrected in substrait-io/substrait#1043, released in v0.88.0. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
yongchul
pushed a commit
to yongchul/substrait
that referenced
this pull request
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The compact aggregate test format uses each inner parenthesis group as a row. The
std_devandvariancetest files were using a flat list of values in a single group, e.g.((1.0, 2.0, 3.0)), which parses as 1 row with 3 columns rather than 3 rows with 1 column.This changes them to the correct per-row format:
((1.0), (2.0), (3.0)).This format is documented here (this is format 2):
substrait/tests/README.md
Lines 71 to 84 in 87d73b6
This came up in some work on
substrait-go.(I opened #1042 to discuss how the inline-format 1 above could be used in the future. We would have to figure out how to deal with intermixing enum args.)
🤖 Generated with Claude Code
This change is