Adding Location Search#100
Conversation
Adding blur and adjusting some default parameters
When location is set in post its doing a location search for the lat and picking the first one sometimes works sometimes it doesn't so i added a patch for that and also the TopSearchesPublicMixin.top_search was broken because it was doing a public request when it should be a private request
adding location_search_pk and location_search_name
adw0rd
left a comment
adw0rd
left a comment
There was a problem hiding this comment.
- Why need storyUpload in photo_upload? Use photo_upload_to_story for uploading photo to story
- extract_locationV2 - broken naming in the project (use extract_location_v2)
- Error using private requests in a public module, this makes no sense (You use private_request in public.py module)
- The rest of the functions for working with GEO (location) will still need to be checked, I did not see any tests on them
|
|
||
| * `path` - Path to source file | ||
| * `caption` - Text for you post | ||
| * `storyUpload` - If True will create a story from image (default: False) |
There was a problem hiding this comment.
Why need storyUpload in photo_upload? Use photo_upload_to_story for uploading photo to story
| "include_reel": "true", | ||
| } | ||
| response = self.public_request(url, params=params, return_json=True) | ||
| response = self.private_request(url, params=params) |
There was a problem hiding this comment.
Error using private requests in a public module, this makes no sense (You use private_request in public.py module)
|
|
||
|
|
||
| def extract_locationV2(data): | ||
| """Extract location info""" |
There was a problem hiding this comment.
extract_locationV2 - broken naming in the project (use extract_location_v2)
|
Thanks for the early location-search work here. I did not merge this old branch directly because it also carried unrelated and already-rejected changes, but I did salvage the useful location-search part onto current master in a clean form: location_search_name(...), location_search_pk(...), proper top_search place/location extraction, docs, and focused regression coverage. Closing this old PR as superseded by that modernized implementation. |
3 participants
No description provided.