Skip to content

Notes update#1380

Closed
nil-malh wants to merge 4 commits into
subzeroid:masterfrom
nil-malh:notes_update
Closed

Notes update#1380
nil-malh wants to merge 4 commits into
subzeroid:masterfrom
nil-malh:notes_update

Conversation

@nil-malh

@nil-malh nil-malh commented Jun 8, 2023

Copy link
Copy Markdown
Contributor

note.py

Fixed the naming of the get_my_notes it was unclear the method returns all the notes from all the user's friends

Created two new methods get_note_by_user that requires the username it returns a NoteResponse object and get_note_content_by_user that requires the username and returns the NoteRequest object, that only contains the text and uuid field.

Fixed the get_all_notes that was returning a json text now it will return an array of NoteResponse that ease the process of retrieving information about a note like the username

extractor.py

Added an extract_note that returns a NoteResponse and extract_note_content method that returns a NoteRequest

types.py

Fixed some BaseModel declarations that were not named according to the response content

Updated the wiki as well

nil-malh added 4 commits June 8, 2023 14:26
…s all the notes from all the user's friends

Created two new methods get_note_by_user that requires the username it returns a NoteResponse object and get_note_content_by_user that requires the username and returns the NoteRequest object, that only contains the text and uuid field.

Fixed the get_all_notes that was returning a json text now it will return an array of NoteResponse
@subzeroid

Copy link
Copy Markdown
Owner

Closing this as outdated. The notes API in current master has already moved to a different shape with get_notes()/create_note()/delete_note() and the Note model, so this older NoteRequest/NoteResponse-based diff no longer merges cleanly or matches the current implementation direction.

@subzeroid subzeroid closed this Apr 15, 2026
@subzeroid

Copy link
Copy Markdown
Owner

Thanks for the original notes cleanup idea. I closed the old PR because it no longer matched the current notes implementation, but I did salvage the part that still made sense on top of current master: helper methods to look up a note or note text by username, plus docs and a focused regression test. That way the useful part of the idea is preserved without reviving the outdated NoteRequest/NoteResponse-based diff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants