fix: close finalized dispute games before claiming bonds#922
Open
fakedev9999 wants to merge 1 commit into
Open
fix: close finalized dispute games before claiming bonds#922fakedev9999 wants to merge 1 commit into
fakedev9999 wants to merge 1 commit into
Conversation
Contributor
|
fakedev9999
force-pushed
the
close-finalized-games
branch
from
May 28, 2026 01:50
4497055 to
a8601e9
Compare
fakedev9999
marked this pull request as ready for review
May 28, 2026 01:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
closeGame()andbondDistributionMode()bindings for fault dispute games.BondDistributionMode.UNDECIDEDare closed before bond claim or cache eviction decisions.Motivation
credit == U256::ZEROis not a reliable lifecycle signal before a game is closed. With a zero init bond, a finalized game can still have zero credit whilebondDistributionModeremainsUNDECIDED, so evicting or skipping it leaves the game unclosed.Behavior change
This intentionally splits the common nonzero-bond flow from
claimCredit()implicitly closing and claiming in one transaction tocloseGame()first, then claiming after the mode is known. That adds one extra transaction for eligible games, but avoids using pre-closecredit()as a lifecycle oracle.Review response
UNDECIDED.Validation
cargo fmt --allcargo clippy --all-features --all-targets -- -D warnings -A incomplete-featurescargo test -p op-succinct-fp --test backup -- --nocapturegit diff --checkNotes
syncintegration tests were retried locally after initializing contract submodules, but the run was aborted after remaining CPU-bound in heavy setup before assertions completed.