Skip to content

[feat] : Add inline message actions#439

Merged
jensenojs merged 2 commits into
sudo-tee:mainfrom
jensenojs:feat/message-actions-dialog
Jul 2, 2026
Merged

[feat] : Add inline message actions#439
jensenojs merged 2 commits into
sudo-tee:mainfrom
jensenojs:feat/message-actions-dialog

Conversation

@jensenojs

@jensenojs jensenojs commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator

Reverting the latest message in the TUI is a very common action for me; I fine-tune my prompts by observing the model's output

iShot_2026-07-02_17 27 16_under10M

@jensenojs jensenojs changed the title Add inline message actions [feat] : Add inline message actions Jul 2, 2026
@jensenojs

Copy link
Copy Markdown
Collaborator Author

The changes for this feature are relatively minor, primarily involving test cases. Therefore, I have merged it first. @sudo-tee

@jensenojs jensenojs merged commit 86f6888 into sudo-tee:main Jul 2, 2026
5 checks passed
@jensenojs jensenojs deleted the feat/message-actions-dialog branch July 2, 2026 09:31
@sudo-tee

sudo-tee commented Jul 2, 2026

Copy link
Copy Markdown
Owner

This is a fairly large commit. I am ok with small MR being merged. But this one is not small 😅 by any means.

Wouldn't it have been simpler to simply use vim.ui.select for listing message actions ?.

@jensenojs

Copy link
Copy Markdown
Collaborator Author

Sorry, I was too impatient.

I didn’t use vim.ui.select because I wanted the actions to stay anchored to the message in the output window and work naturally with mouse clicks there. That required touching the shared dialog/render path, which made the MR larger.

I'll submit a PR to revert this one in a moment. My apologies 🙇‍♂️

@sudo-tee

sudo-tee commented Jul 2, 2026

Copy link
Copy Markdown
Owner

No worries. I don't mind small bug fixes or smaller PR being merged. But for bigger UX features I like testing them out first.

@sudo-tee

sudo-tee commented Jul 2, 2026

Copy link
Copy Markdown
Owner

@jensenojs

I have an issue with the mouse click with this MR. once the output window is focused it will eat all mouse clicks in the editor, so I cannot focus other panes.

Screen.Recording.2026-07-02.091749.mp4

@jensenojs

Copy link
Copy Markdown
Collaborator Author

i will revert it firstly @sudo-tee

@sudo-tee

sudo-tee commented Jul 2, 2026

Copy link
Copy Markdown
Owner

I pushed a fix 2d7e792

oops didn't saw your previous message

@jensenojs

Copy link
Copy Markdown
Collaborator Author

If the confusion caused by this PR makes you feel it's not worth continuing, please don't hesitate to revert it

sudo-tee pushed a commit that referenced this pull request Jul 2, 2026
…ialog" (#440)

This reverts commit 86f6888, reversing
changes made to dc729d2.
@sudo-tee

sudo-tee commented Jul 2, 2026

Copy link
Copy Markdown
Owner

You can always recreate the PR.

I have a couple ideas to simplify things, have you looked at contextual actions ?

image

you can bind theses actions to any line and it would open a menu. I think if would be a great fit for what you want to acheive ?

@jensenojs

Copy link
Copy Markdown
Collaborator Author

( 'ω' ) get!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants