Add CI workflow to run pytest on PRs#22
Open
bradleesand wants to merge 1 commit intosudoStacks:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/workflows/tests.ymlrunning the full pytest suite on Python 3.11main, and viaworkflow_dispatchrequirements.txtpluspytest,pytest-asyncio, andhttpx(needed by FastAPITestClient)Why
There is currently no general CI workflow that runs the test suite — only the targeted
music-search-benchmarkand release workflows. Adding a pytest CI run on every PR will catch regressions and surface the current state of the suite.Notes
tests/test_*api*.py,tests/test_intent_*, etc. currently fail because of a stale test helper that clearsapp.on_startupbut does not re-setapp.state.config_path(a fix exists onarr_integrationbut is part of a larger refactor). Other unrelated failures exist as well. Surfacing these in CI is the first step toward fixing them.Test plan