Skip to content

Commit 2801ece

Browse files
committed
♿️(frontend) change aria-label for help menu button
The help menu button's aria-label was previously "Open onboarding menu", which was not accurate and could be confusing for screen reader users. This commit updates the aria-label to "Open help menu" to better reflect the button's purpose and improve accessibility.
1 parent 0b37996 commit 2801ece

4 files changed

Lines changed: 8 additions & 10 deletions

File tree

src/frontend/apps/e2e/__tests__/app-impress/doc-tree.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -299,7 +299,7 @@ test.describe('Doc Tree', () => {
299299

300300
await page.keyboard.press('Tab');
301301

302-
await expect(page.getByLabel('Open onboarding menu')).toBeFocused();
302+
await expect(page.getByLabel('Open help menu')).toBeFocused();
303303

304304
await page.keyboard.press('Tab');
305305

@@ -309,7 +309,7 @@ test.describe('Doc Tree', () => {
309309

310310
await page.keyboard.press('Shift+Tab');
311311

312-
await expect(page.getByLabel('Open onboarding menu')).toBeFocused();
312+
await expect(page.getByLabel('Open help menu')).toBeFocused();
313313

314314
await page.keyboard.press('Shift+Tab');
315315

src/frontend/apps/e2e/__tests__/app-impress/help.spec.ts

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ test.describe('Help feature', () => {
2727
await expect(page.getByRole('button', { name: 'New doc' })).toBeVisible();
2828

2929
await expect(
30-
page.getByRole('button', { name: 'Open onboarding menu' }),
30+
page.getByRole('button', { name: 'Open help menu' }),
3131
).toBeHidden();
3232
});
3333

@@ -43,7 +43,7 @@ test.describe('Help feature', () => {
4343
},
4444
});
4545

46-
await page.getByRole('button', { name: 'Open onboarding menu' }).click();
46+
await page.getByRole('button', { name: 'Open help menu' }).click();
4747

4848
await getMenuItem(page, 'Onboarding').click();
4949

@@ -87,7 +87,7 @@ test.describe('Help feature', () => {
8787
});
8888

8989
test('closes modal with Skip button', async ({ page }) => {
90-
await page.getByRole('button', { name: 'Open onboarding menu' }).click();
90+
await page.getByRole('button', { name: 'Open help menu' }).click();
9191
await getMenuItem(page, 'Onboarding').click();
9292

9393
const modal = page.getByTestId('onboarding-modal');
@@ -107,9 +107,7 @@ test.describe('Help feature', () => {
107107
// switch to french
108108
await waitForLanguageSwitch(page, TestLanguage.French);
109109

110-
await page
111-
.getByRole('button', { name: "Ouvrir le menu d'embarquement" })
112-
.click();
110+
await page.getByRole('button', { name: "Ouvrir le menu d'aide" }).click();
113111

114112
await getMenuItem(page, 'Premiers pas').click();
115113

src/frontend/apps/impress/src/features/help/components/HelpMenu.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ export const HelpMenu = ({
6060
>
6161
<Box $direction="row" $align="center">
6262
<Button
63-
aria-label={t('Open onboarding menu')}
63+
aria-label={t('Open help menu')}
6464
color={colorButton || 'neutral'}
6565
variant="tertiary"
6666
iconPosition="left"

src/frontend/apps/impress/src/i18n/translations.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -905,7 +905,7 @@
905905
"Open Source": "Open Source",
906906
"Open document {{title}}": "Ouvrir le document {{title}}",
907907
"Open document: {{title}}": "Ouvrir le document : {{title}}",
908-
"Open onboarding menu": "Ouvrir le menu d'embarquement",
908+
"Open help menu": "Ouvrir le menu d'aide",
909909
"Open root document": "Ouvrir le document racine",
910910
"Open the document options": "Ouvrir les options du document",
911911
"Open the menu of actions for the document: {{title}}": "Ouvrir le menu des actions du document : {{title}}",

0 commit comments

Comments
 (0)