Skip to content

Commit 7f9869f

Browse files
committed
♿️(frontend) use aria-haspopup menu on DropButton triggers
Replace aria-haspopup true with menu on DropButton
1 parent 210c8b5 commit 7f9869f

3 files changed

Lines changed: 6 additions & 2 deletions

File tree

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,10 @@ and this project adheres to
66

77
## [Unreleased]
88

9+
### Changed
10+
11+
- ♿(frontend) use aria-haspopup menu on DropButton triggers #2126
12+
913
## [v4.8.4] - 2026-03-25
1014

1115
### Added

src/frontend/apps/impress/src/components/DropButton.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ export const DropButton = ({
9393
onOpenChangeHandler(true);
9494
}}
9595
aria-label={label}
96-
aria-haspopup="true"
96+
aria-haspopup="menu"
9797
aria-expanded={isLocalOpen}
9898
data-testid={testId}
9999
$css={css`

src/frontend/apps/impress/src/components/dropdown-menu/__tests__/DropdownMenu.spec.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ describe('<DropdownMenu />', () => {
9494
);
9595

9696
const trigger = screen.getByRole('button', { name: 'Select language' });
97-
expect(trigger).toHaveAttribute('aria-haspopup', 'true');
97+
expect(trigger).toHaveAttribute('aria-haspopup', 'menu');
9898
expect(trigger).toHaveAttribute('aria-expanded', 'false');
9999

100100
await userEvent.click(trigger);

0 commit comments

Comments
 (0)