Fix/1136 heading order#1251
Closed
Ovgodd wants to merge 2 commits into
Closed
Conversation
Ovgodd
force-pushed
the
fix/1136-heading-order
branch
from
090396e to
3005a8b
Compare
enforces contiguous heading levels to ensure accessibility compliance Signed-off-by: Cyril <c.gromoff@gmail.com>
Ovgodd
force-pushed
the
fix/1136-heading-order
branch
from
3005a8b to
407de29
Compare
adds an end to end test to verify progressive heading suggestions Signed-off-by: Cyril <c.gromoff@gmail.com>
Ovgodd
force-pushed
the
fix/1136-heading-order
branch
from
407de29 to
012b06f
Compare
AntoLC
reviewed
Aug 4, 2025
AntoLC
left a comment
AntoLC
left a comment
Collaborator
There was a problem hiding this comment.
Let's wait a bit with this PR to be sure about the behavior that we want to implement.
We need to validate altogether with @rl-83 and @virgile-dev.
Collaborator
Author
I’ve set this PR to draft in the meantime |
Collaborator
|
Let's close it, I added the label |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR introduces a heading accessibility filter in the slash menu to progressively limit heading levels (H1 → H2 → H3) in the document editor. It also adds an end-to-end test to validate the filtering logic.
that solve issue : 1136
Proposal
Write E2E test to ensure correct progressive filtering behavior (Playwright)