🚸(frontend) allow opening "@page" links with ctrl/command/middle-mouse click#2170
Open
manuhabitela wants to merge 1 commit intosuitenumerique:mainfrom
Open
🚸(frontend) allow opening "@page" links with ctrl/command/middle-mouse click#2170manuhabitela wants to merge 1 commit intosuitenumerique:mainfrom
manuhabitela wants to merge 1 commit intosuitenumerique:mainfrom
Conversation
Links to other pages created through the "@" shortcut are not actual anchor (`<a>`) elements seemingly due to conflicts with lower-lvl code, noticeably when drag&dropping the elements. So those "links" are actually span and we must handle the "link behavior" ourselves. This adds more usual "link behavior" to thoses, allowing users to ctrl+click, command+click, shift+click and middle-mouse click to interact with the links and open them in a new tab or new window. Signed-off-by: Emmanuel Pelletier <manu@habite.la>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey there Docs team 👋
Purpose
Make "interlinking" elements (links to other pages, made through the
@shortcut) usable with ctrl/command/shift+click and mousewheel click to open the link in a new tab or new window.Proposal
Just add additional event listeners on the existing homemade
span. An obviously better solution would have been to find a way to make actual<a>work, but I have to confess I didn't have the motivation to dig deeper. These small changes already make for a better UX I'd say.Things to know:
External contributions
Thank you for your contribution! 🎉
Please ensure the following items are checked before submitting your pull request:
git commit --signoff(DCO compliance)git commit -S)<gitmoji>(type) title description## [Unreleased]section (if noticeable change)