Draft: Grist static preview#292
Draft
vviers wants to merge 8 commits into
Draft
Conversation
vviers
force-pushed
the
grist-static-preview
branch
from
7dea7bc to
b8fb52a
Compare
vviers
commented
Jul 28, 2025
| { | ||
| ...file, | ||
| category: getMimeCategory(file.mimetype), | ||
| category: getMimeCategory(file.mimetype, file.url.split('.').pop() || null), |
vviers
commented
Jul 28, 2025
| <div className="file-preview-title"> | ||
| <img | ||
| src={getIconByMimeType(currentFile.mimetype, "mini").src} | ||
| src={getIconByMimeType(currentFile.mimetype, "mini", currentFile.url.split('.').pop()).src} |
Contributor
Author
There was a problem hiding this comment.
This is a fix. When opening a .grist preview, the header showed a SQLite logo.
Contributor
Author
Grist document previewCapture.video.du.2025-07-28.16-48-53.webmCSV previewCapture.video.du.2025-07-28.17-17-23.webm |
This is needed for the rest of the work. They are the same proportions as other icons
I'll add the Grist exeption in a separate commit
Using the generic logo so its relevant to all instances of drive.
Interops for the win !
A generic SQL icon seems to be OK for now
vviers
force-pushed
the
grist-static-preview
branch
from
24f446f to
ba2a6b1
Compare
with the help of @manuhabitela
vviers
force-pushed
the
grist-static-preview
branch
from
2dcd716 to
0fbd4ee
Compare
NathanVss
force-pushed
the
add_grist_types
branch
2 times, most recently
from
d00d1f7 to
4b07850
Compare
Contributor
Wow it's amazing !! Keep us tuned once the PR is ready, I love it 🤩 |
NathanVss
force-pushed
the
add_grist_types
branch
2 times, most recently
from
fd7ee70 to
b80b850
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #275
Still very much WIP. What remains to be done at the very least:
{credentials: "include"}Wishlist for a separate PR:
Fixes #281