Enhance upload toast with progress, errors and cancel support#595
Merged
Conversation
PanchoutNathan
force-pushed
the
feat/update-upload-toast
branch
from
988cfa9 to
dae37b8
Compare
PanchoutNathan
force-pushed
the
feat/update-upload-toast
branch
from
dae37b8 to
09b733a
Compare
Contributor
|
Please make sure to link the appropriate issue to this PR @PanchoutNathan so we can know which one to close |
NathanVss
reviewed
Mar 25, 2026
Contributor
NathanVss
left a comment
NathanVss
left a comment
There was a problem hiding this comment.
Would be great to add tests about the bugs I found 🪲
PanchoutNathan
force-pushed
the
feat/update-upload-toast
branch
from
09b733a to
a612352
Compare
PanchoutNathan
force-pushed
the
feat/update-upload-toast
branch
from
a612352 to
b6b8f02
Compare
NathanVss
approved these changes
Apr 2, 2026
PanchoutNathan
force-pushed
the
feat/update-upload-toast
branch
7 times, most recently
from
3ddb185 to
4605478
Compare
Refactor createFile to return { promise, abort } instead of a plain Promise,
enabling individual upload cancellation from the UI.
Add a reusable ErrorIcon SVG component and allow IconSvg to accept a raw numeric size in addition to named IconSize values.
PanchoutNathan
force-pushed
the
feat/update-upload-toast
branch
from
4605478 to
e9cd811
Compare
- Add per-file status tracking (uploading/done/error/cancelled) - Show error details inline with tooltips for failed uploads - Display overall progress percentage during upload - Add cancel overlay on hover for individual files - Add confirmation modal when cancelling all uploads - Handle too-large files as inline errors instead of separate toasts - Add translations for error messages and cancel modal (en/fr/nl)
Cover success, file-too-large errors, mixed uploads, cancel individual file, cancel all via confirmation modal, toggle file list, and hover cancel overlay.
PanchoutNathan
force-pushed
the
feat/update-upload-toast
branch
from
f41d21f to
8029d4f
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ErrorIconcomponent and support numeric icon sizesTest plan
upload.spec.ts