Fix/600 improve process item deletion error handling#632
Open
neilcroft wants to merge 1 commit into
Open
Conversation
neilcroft
force-pushed
the
fix/600-improve-process-item-deletion-error-handling
branch
from
becc1c1 to
c74b116
Compare
|
Use process_item_purge to delete stale pending items so that eventual files on the storage are also removed. Closes suitenumerique#600
neilcroft
force-pushed
the
fix/600-improve-process-item-deletion-error-handling
branch
from
c74b116 to
2df020a
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Stale pending items cleaned up by clean_pending_items were removed from the database but their files were left behind on the object storage, leading to orphan files accumulating
over time.
Closes #600
Proposal
Soft-delete then hard-delete pending items, then schedule process_item_purge to clean both the storage file and the database record