Skip to content

🐛(frontend) fix 403 when clicking on a removed file in trash#637

Merged
NathanVss merged 2 commits into
mainfrom
fix/trash-item-click
Apr 7, 2026
Merged

🐛(frontend) fix 403 when clicking on a removed file in trash#637
NathanVss merged 2 commits into
mainfrom
fix/trash-item-click

Conversation

@NathanVss
Copy link
Copy Markdown
Contributor

Summary

  • Intercept file clicks in the trash view to show an informative modal instead of attempting a preview (which caused a 403 redirect)
  • Differentiate modal messages between files and folders for clarity
  • Add onFileClick prop to AppExplorer to allow overriding the default file click behavior
  • Add e2e tests covering trash item click behavior

Closes #601

@NathanVss NathanVss requested a review from PanchoutNathan April 1, 2026 13:10
@NathanVss NathanVss force-pushed the fix/trash-item-click branch from 46e7ee6 to b73ca72 Compare April 1, 2026 14:10
@NathanVss NathanVss force-pushed the fix/trash-item-click branch from b73ca72 to abe8df3 Compare April 7, 2026 09:07
Clicking a deleted file in the trash was trying to open a preview,
causing a 403 redirect. We now intercept file clicks in trash the
same way we do for folders: by showing an informative modal asking
the user to restore the item first. The modal message now also
distinguishes between files and folders for clarity.

Closes #601
Ensure clicking on deleted files and folders in the trash shows
the appropriate modal instead of attempting navigation or preview.
@NathanVss NathanVss force-pushed the fix/trash-item-click branch from abe8df3 to af7d395 Compare April 7, 2026 13:13
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 7, 2026

@NathanVss NathanVss merged commit af7d395 into main Apr 7, 2026
30 checks passed
@NathanVss NathanVss deleted the fix/trash-item-click branch April 7, 2026 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

403 when clicking on a removed file

2 participants