Improve dropdown menu accessibility state and focus#226
Open
web3blind wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses part of #183 for
DropdownMenuby improving the trigger state announcement and keyboard focus visibility.Changes:
aria-haspopup="menu"andaria-expandedto a single trigger element when possiblearia-controlswhile the menu is openAccessibility impact
Screen-reader users can now hear whether the dropdown trigger is expanded or collapsed, and keyboard users get a clearer focus indicator while navigating menu items.
This is intentionally a small, safe step toward the broader dropdown accessibility issue rather than a full rewrite of the component.
Validation
corepack yarn lint— passed with existing warnings in unrelated preview componentscorepack yarn build— passedCloses part of #183.